Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <ff8a005c68e512cb3f338b7381853e6b3a3ab293.camel@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: Pass lockdep expression to RCU lists
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Amol Grover <frextrite@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Joel Fernandes <joel@joelfernandes.org>,
        Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>,
        "Paul E . McKenney" <paulmck@kernel.org>
Date:   Wed, 19 Feb 2020 10:13:36 +0100
In-Reply-To: <20200219091102.10709-1-frextrite@gmail.com> (sfid-20200219_101235_133080_876B0E75)
References: <20200219091102.10709-1-frextrite@gmail.com>
         (sfid-20200219_101235_133080_876B0E75)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-02-19 at 14:41 +0530, Amol Grover wrote:
>  
> -	WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held());
> -
> -	list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list) {
> +	list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list,
> +				lockdep_rtnl_is_held()) {

Huh, I didn't even know you _could_ do that :)

johannes