Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp404905ybv; Wed, 19 Feb 2020 01:58:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzJ03UGgYkColLncL3kCIypRc9OYfqnc+x9wBkrjbKFXQ6euNLxrjZp55uPfSOsnNuVY2S0 X-Received: by 2002:a9d:7cd0:: with SMTP id r16mr19710388otn.50.1582106333664; Wed, 19 Feb 2020 01:58:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582106333; cv=none; d=google.com; s=arc-20160816; b=k7ZNMtVZ7tDVRS4Vk/B315ZJMHOI1PckeSI59oAjDQ28KNnZqKNqi/hKIJC4t8JaXc sSahHYnxL/zFWhP4PrFacHIo+c4vL4x6hbWquNCqHXgIt7cfhFy9zPIjVVljg5L1WgTT uwzZ6/EMv05L3ICWOeyOeK/QaUnt/4U+8zf63qxLEOEYHIZ+DhtcSRzZL+glJIi6L8Tq v8Mw8oj2HOog7uqOx9eIbmOy6Y7zn99pk7HeV+8Di92sqqIVUP0prXUJbGzX9icKL4fg Dwa7GSM8y86pSxZPyYHOn8kLm3h3vDTYmvvz23ks+TUiDb+EhfoPXo6ku/XhOEFpOIpb TKVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=EZwb8kra4dBbg9n0nVwAlwXC7rhh1e3KIsgqclLE2W4=; b=j0KLXfIuYH//PuRe6WppMJyWnrMMeKdv7iOh1882ihlWIlxRneiJBYwJLT9YB8YjE3 v4vv6zJAkU8U8GPnVdNKRzz++vKBeTdrY62QgJOsTBGZ0kNkgvZ/9kr2JNvJxvkzdjlE oupjJmfKkP9xnisAhjMPQI/YMRpYKl1APdpC+HpYQIDnh+FKb/qtWFSh6oYVySnRRe5g ovEkbxHLcxbCMa2uVwAsSJ1oA7dXavYYnGaI6DQByXyYKflu8y2JRuiW6mb+GtwKaapj T2bYpk5/A5EajVL2k7Ir+Rb2KAWr7NtPW7jRcKPX/YQYNSWki+rCpLj+EGMNtLdTadfg RsUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a6si8789541oia.33.2020.02.19.01.58.41; Wed, 19 Feb 2020 01:58:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgBSJ5O (ORCPT + 99 others); Wed, 19 Feb 2020 04:57:14 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:37763 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726385AbgBSJ5O (ORCPT ); Wed, 19 Feb 2020 04:57:14 -0500 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j4M6T-0001jk-Dz; Wed, 19 Feb 2020 10:57:13 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 13812103A05; Wed, 19 Feb 2020 10:57:13 +0100 (CET) From: Thomas Gleixner To: LKML Cc: x86@kernel.org Subject: [PATCH] x86/entry/32: Add missing ASM_CLAC in general_protection entry Date: Wed, 19 Feb 2020 10:57:13 +0100 Message-ID: <87zhdeq4qu.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All exception entry points must have ASM_CLAC right at the beginning. The general_protection entry is missing one. Fixes: e59d1b0a2419 ("x86-32, smap: Add STAC/CLAC instructions to 32-bit kernel entry") Signed-off-by: Thomas Gleixner Cc: stable@vger.kernel.org --- arch/x86/entry/entry_32.S | 1 + 1 file changed, 1 insertion(+) --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -1681,6 +1681,7 @@ SYM_CODE_START(int3) SYM_CODE_END(int3) SYM_CODE_START(general_protection) + ASM_CLAC pushl $do_general_protection jmp common_exception SYM_CODE_END(general_protection)