Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 net-next] sfc: remove unused variable
 'efx_default_channel_type'
To:     YueHaibing <yuehaibing@huawei.com>,
        <linux-net-drivers@solarflare.com>, <ecree@solarflare.com>,
        <davem@davemloft.net>, <amaftei@solarflare.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20200211141606.47180-1-yuehaibing@huawei.com>
 <20200219013458.47620-1-yuehaibing@huawei.com>
From:   Martin Habets <mhabets@solarflare.com>
Message-ID: <14ded279-719b-41f6-0ee6-56e782f9cfb5@solarflare.com>
Date:   Wed, 19 Feb 2020 12:35:40 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200219013458.47620-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 19/02/2020 01:34, YueHaibing wrote:
> drivers/net/ethernet/sfc/efx.c:116:38: warning:
>  efx_default_channel_type defined but not used [-Wunused-const-variable=]
> 
> commit 83975485077d ("sfc: move channel alloc/removal code")
> left behind this, remove it.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 83975485077d ("sfc: move channel alloc/removal code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Martin Habets <mhabets@solarflare.com>

> ---
> v2: Add Fixes tag
> ---
>  drivers/net/ethernet/sfc/efx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 4481f21..256807c 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
>   *
>   *************************************************************************/
>  
> -static const struct efx_channel_type efx_default_channel_type;
>  static void efx_remove_port(struct efx_nic *efx);
>  static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
>  static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);
>