Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp544321ybv; Wed, 19 Feb 2020 04:40:41 -0800 (PST) X-Google-Smtp-Source: APXvYqyuHeHWR2QHCfhHHXEBL+k8L31Npy4vS8kTnex0PNhThvjlocLNkFnAZ5hknetzYudQLTKv X-Received: by 2002:a9d:76d6:: with SMTP id p22mr19905459otl.37.1582116040979; Wed, 19 Feb 2020 04:40:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582116040; cv=none; d=google.com; s=arc-20160816; b=OgQi869Bi2akQDXPx8pErDWghT9qP7OMaF2Zmk5y+Zi9L4NE4vo7OxD9pjInKHHqit B98OW838NPToXiYG7qSyc9nk8d0DQQsHSy5yvtSAIrw+xsWgibIB3OTLFRV0Bo5+R9/S F5Ja1Gnanrh6Ge+Oi8e3kVHTVp7G9kMl5V+yqzBEOR+HWRk6TCSnckqWA2up5l2lXWgp +XlKsFKVgukcwGnOYblR6rKtYbiAUOs6hdlJGzlqBU2AxmhzZOB8XP0yJoNn66R+ybuh LhSHRk6dZ1ZN835n0umXOJ3iqLtyA34tIIqy2ej8w7SE/TZoK4gIak/tVzG4q+dY1LJH 940Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=dvogZxARm7+3NjFHeyWhSbX6GL1BQAy/1MQV8wA3kxA=; b=ihH8rsy0WSeVqr3PnswNjZQYlp+nos+U1YulRtdzNEjdB5qZZLFCAjyFJDNEOz7NQl nRkcgp1gLJyaQLRg/g/Ea9bagBoAmiOhJDJ7G8RrwHjPnxSSK6RVd1ZEILx1oTRCEb1r wFc1MVdwChtFFsVO1FjeeWue5pYT8aY2LaQ3K/gOrA7vvuW7z8Knd5BWi9SftLOp8jSt yINT8heYohz/CuZ+ATsq4Koq79N4xLa3B5hb+kJIhOFCas0CBc4sORoL5Xp4gn9UPpKj GJcfLMVArKX+F2AtyO/KAHjGIixiwe71UhOF3i6fQooeLoVlFfNz+2hq/fsGD77/nv5I KusQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k202si8973639oih.244.2020.02.19.04.40.29; Wed, 19 Feb 2020 04:40:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727851AbgBSMkF (ORCPT + 99 others); Wed, 19 Feb 2020 07:40:05 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:57039 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727833AbgBSMkD (ORCPT ); Wed, 19 Feb 2020 07:40:03 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 48My3h6S2Rz9sSd; Wed, 19 Feb 2020 23:40:00 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 477f3488a94e35380c82a7498d46f10fa5f3edd2 In-Reply-To: <7bce32ccbab3ba3e3e0f27da6961bf6313df97ed.1581663140.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Larry Finger From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/6xx: Fix power_save_ppc32_restore() with CONFIG_VMAP_STACK Message-Id: <48My3h6S2Rz9sSd@ozlabs.org> Date: Wed, 19 Feb 2020 23:40:00 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-02-14 at 06:53:00 UTC, Christophe Leroy wrote: > power_save_ppc32_restore() is called during exception entry, before > re-enabling the MMU. It substracts KERNELBASE from the address > of nap_save_msscr0 to access it. > > With CONFIG_VMAP_STACK enabled, data MMU translation has already been > re-enabled, so power_save_ppc32_restore() has to access > nap_save_msscr0 by its virtual address. > > Reported-by: Larry Finger > Signed-off-by: Christophe Leroy > Fixes: cd08f109e262 ("powerpc/32s: Enable CONFIG_VMAP_STACK") > Tested-by: Larry Finger Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/477f3488a94e35380c82a7498d46f10fa5f3edd2 cheers