Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 19 Feb 2020 04:47:13 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Amol Grover <frextrite@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Joel Fernandes <joel@joelfernandes.org>,
        Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Subject: Re: [PATCH] cfg80211: Pass lockdep expression to RCU lists
Message-ID: <20200219124713.GU2935@paulmck-ThinkPad-P72>
Reply-To: paulmck@kernel.org
References: <20200219091102.10709-1-frextrite@gmail.com>
 <ff8a005c68e512cb3f338b7381853e6b3a3ab293.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ff8a005c68e512cb3f338b7381853e6b3a3ab293.camel@sipsolutions.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 19, 2020 at 10:13:36AM +0100, Johannes Berg wrote:
> On Wed, 2020-02-19 at 14:41 +0530, Amol Grover wrote:
> >  
> > -	WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held());
> > -
> > -	list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list) {
> > +	list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list,
> > +				lockdep_rtnl_is_held()) {
> 
> Huh, I didn't even know you _could_ do that :)

It is a fairly recent addition, courtesy of Joel Fernandes.  ;-)

							Thanx, Paul