Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750833AbWBIXlZ (ORCPT ); Thu, 9 Feb 2006 18:41:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750835AbWBIXlZ (ORCPT ); Thu, 9 Feb 2006 18:41:25 -0500 Received: from stat9.steeleye.com ([209.192.50.41]:52130 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1750832AbWBIXlY (ORCPT ); Thu, 9 Feb 2006 18:41:24 -0500 Subject: Re: a couple of oopses with 2.6.14 From: James Bottomley To: Andrew Morton Cc: bernd-schubert@gmx.de, bernd.schubert@pci.uni-heidelberg.de, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org In-Reply-To: <20060209152744.00de43f6.akpm@osdl.org> References: <200602091934.20732.bernd.schubert@pci.uni-heidelberg.de> <20060209152744.00de43f6.akpm@osdl.org> Content-Type: text/plain Date: Thu, 09 Feb 2006 18:41:11 -0500 Message-Id: <1139528472.3275.60.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 26 On Thu, 2006-02-09 at 15:27 -0800, Andrew Morton wrote: > So we have a sata problem. It triggered two scsi bugs. The first (a > warning) is being fixed. I don't know if the second has been fixed. The second should be fixed by this: author goggin, edward Tue, 8 Nov 2005 20:02:23 +0000 (15:02 -0500) commit 34ea80ec6a02ad02e6b9c75c478c18e5880d6713 [SCSI] fix usb storage oops The problem is that scsi_run_queue is called from scsi_next_command() after doing a scsi_put_command. If the command was the only thing holding the reference on the scsi_device then the resulting device put will tear down the block queue. Fix this by taking a reference to the device and holding it around scsi_run_queue() James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/