Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
CC:     Felipe Balbi <balbi@kernel.org>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Bin Liu <b-liu@ti.com>, Benson Leung <bleung@chromium.org>,
        Prashant Malani <pmalani@chromium.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 5/9] usb: roles: Provide the switch drivers handle to the
 switch in the API
Thread-Topic: [PATCH 5/9] usb: roles: Provide the switch drivers handle to the
 switch in the API
Thread-Index: AQHV4nD6G15oErWo00iXG8zLCuhxYqgZHzyAgAd0koCAAFRlgIAA4yEAgADDdoCAAAjZgA==
Date:   Wed, 19 Feb 2020 14:09:54 +0000
Message-ID: <20200219140955.GA15569@b29397-desktop>
References: <20200213132428.53374-1-heikki.krogerus@linux.intel.com>
 <20200213132428.53374-6-heikki.krogerus@linux.intel.com>
 <20200213133239.GN1498@kuha.fi.intel.com>
 <20200218072341.GA30350@b29397-desktop>
 <20200218122545.GF28776@kuha.fi.intel.com>
 <20200219015840.GC8602@b29397-desktop>
 <20200219133815.GH28776@kuha.fi.intel.com>
In-Reply-To: <20200219133815.GH28776@kuha.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D720C75BB1073948831A63342843B422@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b8ba266c-f63d-4920-b34c-08d7b54564af
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2020 14:09:54.1142
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4phJWA8nmZrNHokEfhdXpwdKwnrX7Tv3CZyhAEH/MGEslUQXtQjoJrfx3cNhN6oYWS+sptqkk9fGFGuGMYDV/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6336
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-02-19 15:38:15, Heikki Krogerus wrote:
> On Wed, Feb 19, 2020 at 01:58:38AM +0000, Peter Chen wrote:
> > On 20-02-18 14:25:45, Heikki Krogerus wrote:
> > > Hi,
> > >=20
> > > On Tue, Feb 18, 2020 at 07:23:41AM +0000, Peter Chen wrote:
> > > > > > @@ -1118,6 +1119,7 @@ static int ci_hdrc_probe(struct platform_=
device *pdev)
> > > > > >  	}
> > > > > > =20
> > > > > >  	if (ci_role_switch.fwnode) {
> > > > > > +		ci_role_switch.driver_data =3D ci;
> > > > > >  		ci->role_switch =3D usb_role_switch_register(dev,
> > > > > >  					&ci_role_switch);
> > > >=20
> > > > Why the struct usb_role_switch_desc needs drvdata, the struct
> > > > usb_role_switch has already one?
> > >=20
> > > I'm assuming that you are asking why not just register the switch,
> > > and then call usb_role_switch_set_drvdata(), right?
> >=20
> > Yes.
> >=20
> > >=20
> > > That may create a race condition where the switch is accessed before
> > > the driver data is available. That can happen for example if the
> > > switch is exposed to the user space.
> > >=20
> > > To play it safe, supplying the driver data as part of the descriptor.
> > > That way we can be sure that the driver data is always available
> > > the moment the switch is registered.
> > >=20
> >=20
> > Then, you may use the uniform way for the driver. Some may have
> > race condition like you said.
>=20
> Uniform way for the driver?
>=20

Sorry, unify way. Take chipidea and cdns3 as an example, at chipidea you
use struct usb_role_switch_desc

+               ci_role_switch.driver_data =3D ci;
                ci->role_switch =3D usb_role_switch_register(dev,
			&ci_role_switch);

But at cdns3 side, you set usb_role_switch drvdata directly.
+       usb_role_switch_set_drvdata(cdns->role_sw, cdns);

But according to your comments, all the driver needs to use chipidea's
way to avoid race condition.

--=20

Thanks,
Peter Chen=