Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 19 Feb 2020 09:18:59 -0600
From:   Rob Herring <robh@kernel.org>
To:     min.li.xe@renesas.com
Cc:     mark.rutland@arm.com, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: ptp: Add device tree
 binding for IDT 82P33 based PTP clock
Message-ID: <20200219151859.GA5294@bogus>
References: <1581114255-6415-1-git-send-email-min.li.xe@renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1581114255-6415-1-git-send-email-min.li.xe@renesas.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 07, 2020 at 05:24:15PM -0500, min.li.xe@renesas.com wrote:
> From: Min Li <min.li.xe@renesas.com>
> 
> Add device tree binding doc for the PTP clock based on IDT 82P33
> Synchronization Management Unit (SMU).
> 
> Changes since v1:
>  - As suggested by Rob Herring:
>    1. Drop reg description for i2c
>    2. Replace i2c@1 with i2c
> 
> Signed-off-by: Min Li <min.li.xe@renesas.com>
> ---
>  .../devicetree/bindings/ptp/ptp-idt82p33.yaml      | 45 ++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/ptp/ptp-idt82p33.yaml
> 
> diff --git a/Documentation/devicetree/bindings/ptp/ptp-idt82p33.yaml b/Documentation/devicetree/bindings/ptp/ptp-idt82p33.yaml
> new file mode 100644
> index 0000000..4c8f87a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ptp/ptp-idt82p33.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ptp/ptp-idt82p33.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IDT 82P33 PTP Clock Device Tree Bindings
> +
> +description: |
> +  IDT 82P33XXX Synchronization Management Unit (SMU) based PTP clock
> +
> +maintainers:
> +  - Min Li <min.li.xe@renesas.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - idt,82p33810
> +      - idt,82p33813
> +      - idt,82p33814
> +      - idt,82p33831
> +      - idt,82p33910
> +      - idt,82p33913
> +      - idt,82p33914
> +      - idt,82p33931
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg

Needs a:

addtionalProperties: false

> +
> +examples:
> +  - |
> +    i2c {
> +        compatible = "abc,acme-1234";
> +        reg = <0x01 0x400>;

Drop these 2 properties.

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        phc@51 {
> +            compatible = "idt,82p33810";
> +            reg = <0x51>;
> +        };
> +    };
> -- 
> 2.7.4
>