Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp733600ybv; Wed, 19 Feb 2020 08:10:52 -0800 (PST) X-Google-Smtp-Source: APXvYqx8I1BFe+TerStl9gWt2+3uct7OnU7XvtNAeFQWXZsrVsO86eRbdxQncz6L3j0konzAoe0q X-Received: by 2002:a05:6830:184:: with SMTP id q4mr20369631ota.232.1582128652526; Wed, 19 Feb 2020 08:10:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582128652; cv=none; d=google.com; s=arc-20160816; b=xqNd7+h8EALOL1gKGz/Go1iv9ULxlrnodGzzXFFX0G0YSml4Uj97PYtzHJzo6Ac7pR YKf9Ox41VcFBfYlvjJbynUwUbolxdr1i3B/uTtbfgAsVoqv/v7abNPtoC0nqk1gh0gB6 INTh/DQkVSZQ8JZuGRdqf0b5VD5ls7QWinLWSsICxzJ/yl3Dc51X79cF9Utkp0M2fg8b Huu/ehW0tRE+UCw1ETCuvgzwYXSXbgEKmjZH/zTgq3YjWmOAF6/OtKrVnXdPBaGym1XM imtnWGqhkHyZ2o75nTHw8SM0t5AGKJiPLaBk8B5UgXgpFZiUhJeS04KHmm5KBzX1UzZ6 atVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:cc; bh=Y4IVG9EdM9GGqYVDnKSi7S7GV3/7tEnqSahIk5yOcYk=; b=YJ8Wfft6GCawCisGh6w2wzj+Clf4hva+ty/PGS4AW8ysMA585HRPm1gvwPkGmvFzVO fB5Ah8WD/RMQvvV6OIt5pfD3mNNJIO9nh0z6wR3WUmNoi8wq/J4HC2jQej0uCv6hj/Fb OlB2C2/oAB8g7ytnDz2+8lbOgiQ4cHwYXp8IRn1DWcIgHaNnUFP6lp/S+RctqilS6Jhr Xjl0E02NE/OenQl7uV3h4CNoIIlXOi9AR8RQByV2vFic7x/NI3lLRxfu/Tpub8+foz9T v5F+F3drd4DIQ+HUf9qeMthO5VN5SWxs5gI0BeIiDn/emPaB81qz+gJDcCTwoNsxNKNV Wb2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=YRz9DrxY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si81905otf.37.2020.02.19.08.10.31; Wed, 19 Feb 2020 08:10:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=YRz9DrxY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbgBSQKZ (ORCPT + 99 others); Wed, 19 Feb 2020 11:10:25 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:18562 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbgBSQKZ (ORCPT ); Wed, 19 Feb 2020 11:10:25 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 19 Feb 2020 08:09:51 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 19 Feb 2020 08:10:24 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 19 Feb 2020 08:10:24 -0800 Received: from [10.25.75.111] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Feb 2020 16:10:14 +0000 CC: , , , , , , , , , , , , , , , Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Dmitry Osipenko , Jon Hunter References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> <264d3354-8a2e-ee12-44ae-aff69213d551@nvidia.com> <075e476a-36bb-5fee-15bc-76af4474a797@gmail.com> <3b42c858-733b-0d17-f457-8043d97f5058@gmail.com> <62b8ffbc-aa32-ae44-6cb4-b176b8ba9b0e@nvidia.com> <847739f8-6f54-cf64-54b8-94707944850b@gmail.com> From: Sameer Pujar Message-ID: <319a0922-3de2-5d02-65c3-d96036eea6d9@nvidia.com> Date: Wed, 19 Feb 2020 21:40:09 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <847739f8-6f54-cf64-54b8-94707944850b@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582128591; bh=Y4IVG9EdM9GGqYVDnKSi7S7GV3/7tEnqSahIk5yOcYk=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=YRz9DrxYbhYO6MTRtYvDuHjxISyreNHeLWM8zCWFBDDruqQ7Iu/eWxWcpvrSipAeN +y1QGqIhOVyKFac4zZXp91ebRRec/wz5LQD9o107Ixrks2W4G92ivh3VWFmmT7y/rn fS2qsZQFF36hhMiEBBEhcg/GFGcrYiNQb4RZF2O624d0UvCmvR5ul6qKf+PBYdwWcg JwnX7UiisfcEa6rwlhs5yQTsza33PiBpoZIydDJecnDrCyppBbpk2nc4AZ+X797Va2 kRck5XiZTa3GPHWP+xfSbLUeCSCTquzreb9s3RTCFY3SNL/0l1bHFcF0ZsEI6rxT1a wgbd5x3qJtG6Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/18/2020 6:30 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 14.02.2020 17:05, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 29/01/2020 03:41, Dmitry Osipenko wrote: >> >> ... >> >>> The !RPM case isn't supported by Tegra anymore in upstream kernel. I'm >>> trying to help to make yours driver better and gave you reasons to >>> remove the unneeded code, while you're keep saying that "there is no >>> harm to retain it", which is not a reason to clutter up the code. I >>> don't feel that it's worthwhile to continue arguing here. >> On further review, it does look like a reasonable argument to get rid of >> this now completely. Like you see less clutter and the soc-core should >> ensure that the card is shutdown before unloading. OK, so fine with me. > And the RPM core ensures that state is synced on disable, sorry if I > didn't make it clear before. > > +1 for less clutter :) Done, I am removing explicit RPM suspend in the next revision. Thanks=20 Dmitry and Jon.