Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 19 Feb 2020 18:43:11 +0200
From:   Ido Schimmel <idosch@mellanox.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc:     Jiri Pirko <jiri@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mlxsw: Replace zero-length array with
 flexible-array member
Message-ID: <20200219164311.GA348671@splinter>
References: <20200218205705.GA29805@embeddedor>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200218205705.GA29805@embeddedor>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (193.47.165.251) by ZR0P278CA0024.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.17 via Frontend Transport; Wed, 19 Feb 2020 16:43:13 +0000
X-Originating-IP: [193.47.165.251]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 65e7fe17-f860-4785-016f-08d7b55ad01b
X-MS-TrafficTypeDiagnostic: AM0PR05MB4338:|AM0PR05MB4338:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM0PR05MB43380990BDB5B3DEAC08B2E6BF100@AM0PR05MB4338.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-Forefront-PRVS: 0318501FAE
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(396003)(136003)(376002)(366004)(346002)(39860400002)(199004)(189003)(6486002)(81166006)(8676002)(52116002)(66476007)(54906003)(6496006)(16526019)(956004)(81156014)(66946007)(186003)(66556008)(966005)(8936002)(2906002)(26005)(9686003)(478600001)(33656002)(316002)(1076003)(86362001)(4326008)(5660300002)(33716001)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB4338;H:AM0PR05MB6754.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
Received-SPF: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HMg48+jLq6Vnb4m3Hx18o2RTUjj0z2A5fnZ76CCTI/My0t5fnpfyUbrwtzPhWDAXwzWsiQC1V9BJlJlGyJ0Cf2XF9e5O3aZfwejL+/9FxO89w5u004Ye1/B6kSNN1PuBolJbEmGn42IfiG5DIju5lFCi4foLaxsmUtJUkf3kymccnv6g26QDjcK/lV0Vfgr66Z4XUBji8Z0m6jMmD8cclL8rUHb+39/x5x2D0FkCvyyhdjvlGWxYHCVQnJ1QTx2YdFlHNJZ6iUTKZOuUGNTi9fF5agzc3lYnqw7aspyEAgCbpvxsSPPNusTYaF0FPEgI42fqJpM9/b6zf+jXlfRC1Tl1sPO0/BbJO5zTwsjvNrky0ovX68ruW5xm2+86LYw59r0o5vilGg/hi2yXWf08u6cnh8zMzI9SqYnnGpNWSt8PxU7noHllnKsntV5e1t+YtsFD972M7zOcKsvjEOBswrDzcppT9XfzOZJ7eBjuyBjvWV2/OdlLfP66aOaVQIMt1qKyYWbq2mEOS/AgFwCrjA==
X-MS-Exchange-AntiSpam-MessageData: zUocK6XZwkfSyecuqgdCVsJavDM65/k1OwKejoiV3mdYhnjMHNu+0Cf6mKMsOf/+2iP4TKfipLGmXfB1mc7tvrEaHlZ7g7WVx5TOdV74AG/C7osLIE3PM7T/SYgM7KHkuW4iPO2eDQ/iTeN5O2wo+A==
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65e7fe17-f860-4785-016f-08d7b55ad01b
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2020 16:43:14.1051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lEjVgDu8MlgyDqEL26iT36rlr/o+r971c6SlwDHSssMRBc7oPMZcR3mHx9OAXr07oOK580foozmsCAGMVpYzHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4338
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 18, 2020 at 02:57:05PM -0600, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
> 
> struct foo {
>         int stuff;
>         struct boo array[];
> };
> 
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertently introduced[3] to the codebase from now on.
> 
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
> 
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of
> zero-length arrays, sizeof evaluates to zero."[1]
> 
> This issue was found with the help of Coccinelle.
> 
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Thanks, Gustavo. Looks good to me. Ran a few tests with a debug config
and nothing exploded.

I was just about to submit some patches myself, but they will conflict
with this patch, so I will wait :)

Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>