Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp818920ybv; Wed, 19 Feb 2020 09:52:04 -0800 (PST) X-Google-Smtp-Source: APXvYqzT9RXP+NdtZ7Lh5Rh6v10UhW50C4tdtNf/hEa2nVLRG49e6mbZrn/P3rR/t67LUIzzK0Dz X-Received: by 2002:a05:6808:8e1:: with SMTP id d1mr5297287oic.68.1582134724124; Wed, 19 Feb 2020 09:52:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582134724; cv=none; d=google.com; s=arc-20160816; b=cc/U0Ljc8NnGajIbtlYvFLrgqJWghN3mktKmx5L6BuJp1RgGKxWUeQm4jMkgwR6l9h 2LsnMb7Wy922RnKbA73pZYd+9cnWrO+bMKKKI0xLmdETNkT+q3L2G4oa3Gu8BoAnLF8k DYqkR3Sd7K4be3lQEHDXevOFrhZ8ts5xVSgbrNjFqsQ0NrtcK7O0xVW/K8dLwevFyZvI UHhnrEl32L5lHYbKbNB0NwA7ddLBiH8j/pYBOR9MqMeFPaYcDOyB4QSITxMv8Opb1vIK LC/BBQyZ6nKJjYhhiaDxwraHGaHxkLubLXtXWg+urW7mRDzr+LJfNt9agxGCbQrOZnFH rBqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=aMpuwLS5+ED0JDvM1wNEebIBOf2WuCBOUBWJUaOKJDM=; b=1E6N1fmDM1tWf2/u4AORA9kg2/MrfMrFRZhFvVV7z/uzvQiLGOjyYwxnW0VcjuX8d6 SLg1SiEy1fcpn0OCvoOS3GsCLpOcoQfbIAxLFXb+erYBRe4pi236IHke3wapGJFDUgi2 J2oNgd5AHiDzK94VFKS2KjgCupLNklwRIDAQEKB855a8+4UFgr2okm3/MFwzWl9JxWXf b4WOzA8nUfQQf1kkK5fwWwUc7eMBW6lMwLQWZ3mYZL6/OKyS7v9CjM00NuHsvCTH7AeG zHYhEPSOdfXXTjwSRhxXDwoh/T7CFcO5qkfIbu4iigLbVoF33AaVZfKGGlJT5efJW9sM c1rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="vI/dKxPu"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p191si9878814oic.257.2020.02.19.09.51.52; Wed, 19 Feb 2020 09:52:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="vI/dKxPu"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgBSRv2 (ORCPT + 99 others); Wed, 19 Feb 2020 12:51:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:50576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgBSRv1 (ORCPT ); Wed, 19 Feb 2020 12:51:27 -0500 Received: from localhost.localdomain (unknown [194.230.155.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FC1924676; Wed, 19 Feb 2020 17:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582134686; bh=In453WSVvUaFgHBMA1oBw+69jXyttH+lqOZnSOfK/wQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vI/dKxPubIJE2GgV5UchLvQrBoYt5IvUaxtPt8lwVF/YTjZ8YYQYrIZvPzBQLaxmb g4C9G9VFhQYxNExoIfCvmn1+lgjPvwSiMDcejVBPXhNFvH0uWaIfAK/0HCnRG0Q+sp tP6wrsb+HFbewa8DkryYbNvFN8TOtQozm5kXGMtg= From: Krzysztof Kozlowski To: Richard Henderson , Ivan Kokshaysky , Matt Turner , Alexey Brodkin , Vineet Gupta , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Yoshinori Sato , Rich Felker , Dave Airlie , David Airlie , Daniel Vetter , Ben Skeggs , Mauro Carvalho Chehab , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S. Miller" , Dave Jiang , Jon Mason , Allen Hubbe , "Michael S. Tsirkin" , Jason Wang , Arnd Bergmann , Geert Uytterhoeven , Andrew Morton , Thomas Gleixner , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, virtualization@lists.linux-foundation.org, linux-arch@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH v2 2/9] rtl818x: Constify ioreadX() iomem argument (as in generic implementation) Date: Wed, 19 Feb 2020 18:50:00 +0100 Message-Id: <20200219175007.13627-3-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200219175007.13627-1-krzk@kernel.org> References: <20200219175007.13627-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among architectures. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven Acked-by: Kalle Valo --- Changes since v1: 1. Add Geert's review. 2. Add Kalle's ack. Fix subject prefix. --- drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h b/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h index 7948a2da195a..2ff00800d45b 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h +++ b/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h @@ -150,17 +150,17 @@ void rtl8180_write_phy(struct ieee80211_hw *dev, u8 addr, u32 data); void rtl8180_set_anaparam(struct rtl8180_priv *priv, u32 anaparam); void rtl8180_set_anaparam2(struct rtl8180_priv *priv, u32 anaparam2); -static inline u8 rtl818x_ioread8(struct rtl8180_priv *priv, u8 __iomem *addr) +static inline u8 rtl818x_ioread8(struct rtl8180_priv *priv, const u8 __iomem *addr) { return ioread8(addr); } -static inline u16 rtl818x_ioread16(struct rtl8180_priv *priv, __le16 __iomem *addr) +static inline u16 rtl818x_ioread16(struct rtl8180_priv *priv, const __le16 __iomem *addr) { return ioread16(addr); } -static inline u32 rtl818x_ioread32(struct rtl8180_priv *priv, __le32 __iomem *addr) +static inline u32 rtl818x_ioread32(struct rtl8180_priv *priv, const __le32 __iomem *addr) { return ioread32(addr); } -- 2.17.1