Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp819150ybv; Wed, 19 Feb 2020 09:52:23 -0800 (PST) X-Google-Smtp-Source: APXvYqx7L6YK52yRek5HTjguo05edCHNyXSFyYFKLNlLOS/cb8u+RPvAMkGN8/ZjTDBSJoqSeXvq X-Received: by 2002:a05:6808:2cd:: with SMTP id a13mr5422741oid.82.1582134743527; Wed, 19 Feb 2020 09:52:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582134743; cv=none; d=google.com; s=arc-20160816; b=nGMLg7rMkPJBCTEA/eRwjTopviKwHsCGBLKNozPGT0L8EclaTkYN1vy4JAu+LFNObt 9YozNcgrLweaDRSIO6EOLcxL1DwBGOMj46TuEBjXPf8o2TVkjCmK36UCDj/UB0xqGQj/ J/HkjYs59891JFzRkxjtOTEhLeLnFjkB1twJAE29X/QrMrn+QFwnOuVyv5acnem9NoPL mgcOZKfZQj4AuW7ZP2U717suXwEdAzI/jK8HOKPtOjFghlBnqVXQPVTFvySN8m3z6c6s Sf6DAmfp33ovUEfx+DK2LpDnEETDzYAQ04TPiN2aECys1iRnO39GmXUPgc79PdFacReX 5/Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=mQMIBEfElIB3kvBnOsuCEqCsG8lgAhZ47Rfx4ZM1zmQ=; b=BV1uFNnFlWxszG0k1rEcydJ71D5dvnbchgTjnzkxpLLY161A4VKqEXmz/BjbOPB0Di PV9UcAbhkHAwNx2VKFRK8S+5x/WoZKKh3G2PFvcMPSCI3Up73SaJa7Ryq3gsT+uw+YS1 avircw62n9vlIGhD5SZ5sicvk/GbkcvP6ceteks8XTfMbNeh5KoAJVD4EDl9SmhvnAbo ARbFbdLD3zSppKYupHdCiQFkXVYoA6g5RyRREYQRtQNZZ3myRPEUxxx2hf6F7r2j7IyM dxd2awSn1yBSTIrGqAGWoL/yLhUqhaEJ2ZOBdT05A2vpZtLXqcQtVWztMNoM/m5TH6Ur Ll5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Nps+RvDL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i15si234253otk.120.2020.02.19.09.52.11; Wed, 19 Feb 2020 09:52:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Nps+RvDL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbgBSRvt (ORCPT + 99 others); Wed, 19 Feb 2020 12:51:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:51016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbgBSRvt (ORCPT ); Wed, 19 Feb 2020 12:51:49 -0500 Received: from localhost.localdomain (unknown [194.230.155.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A50C2467A; Wed, 19 Feb 2020 17:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582134708; bh=GncZJES9Pi+VGkKtqPts7U7bz/5zDiGW+ajpMZK1gUg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nps+RvDLKubC92VpmGQNWlndGFmfjWMGeb/g/eNgFR+xzszyfLi3xXawp++hyqb4m ORI6JWrkg6Q0W5ZsjhcSlCeeWNf6wixSeJxFI9h33iYowSawPTurEgX2Wj3C+53d5H P0IAjNbkxQCAyEjUuRHhnl2u9svOTEBYnry5h4XA= From: Krzysztof Kozlowski To: Richard Henderson , Ivan Kokshaysky , Matt Turner , Alexey Brodkin , Vineet Gupta , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Yoshinori Sato , Rich Felker , Dave Airlie , David Airlie , Daniel Vetter , Ben Skeggs , Mauro Carvalho Chehab , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S. Miller" , Dave Jiang , Jon Mason , Allen Hubbe , "Michael S. Tsirkin" , Jason Wang , Arnd Bergmann , Geert Uytterhoeven , Andrew Morton , Thomas Gleixner , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, virtualization@lists.linux-foundation.org, linux-arch@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH v2 4/9] virtio: pci: Constify ioreadX() iomem argument (as in generic implementation) Date: Wed, 19 Feb 2020 18:50:02 +0100 Message-Id: <20200219175007.13627-5-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200219175007.13627-1-krzk@kernel.org> References: <20200219175007.13627-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among architectures. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven --- Changes since v1: 1. Add Geert's review. --- drivers/virtio/virtio_pci_modern.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c index 7abcc50838b8..fc58db4ab6c3 100644 --- a/drivers/virtio/virtio_pci_modern.c +++ b/drivers/virtio/virtio_pci_modern.c @@ -26,16 +26,16 @@ * method, i.e. 32-bit accesses for 32-bit fields, 16-bit accesses * for 16-bit fields and 8-bit accesses for 8-bit fields. */ -static inline u8 vp_ioread8(u8 __iomem *addr) +static inline u8 vp_ioread8(const u8 __iomem *addr) { return ioread8(addr); } -static inline u16 vp_ioread16 (__le16 __iomem *addr) +static inline u16 vp_ioread16 (const __le16 __iomem *addr) { return ioread16(addr); } -static inline u32 vp_ioread32(__le32 __iomem *addr) +static inline u32 vp_ioread32(const __le32 __iomem *addr) { return ioread32(addr); } -- 2.17.1