Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp819392ybv; Wed, 19 Feb 2020 09:52:47 -0800 (PST) X-Google-Smtp-Source: APXvYqzA0/7Vh6hB8AnfKHchNzaJlMvlp0gLF2QDrI6KtD8FU4AdR8eHLUFbtL1T98gnpNEoaShh X-Received: by 2002:aca:af09:: with SMTP id y9mr5046817oie.101.1582134767198; Wed, 19 Feb 2020 09:52:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582134767; cv=none; d=google.com; s=arc-20160816; b=qzWLPy1nB9ygU93e1+HgK8nFq6M7HcxSG3XjoOQ/V7vx6uXIZPl/DK7goMPJjsL85F TJ7XnZ4L1er3Rc4rGodtoBahrf3+mkL0zGVdXjhWMv0g9Hb0zbscAkIIo/ix/dj2s3c7 1c8P2jL1klUD/19gvbF5ZMjeT8A0QPeA+iN6yjPFyaPBgXIS9jxnd14lE8LC25rBqeat MtAgl52pd7F24oYyMLRs/1g9KdkhkdVN/lgiRXxJ3ClEZbUzjEeaV5tPS1+ELwkOMO+g TAeWB+42upJynfAOslilnxRm9Sf47vBzPUyuvBjgOJfGaxF9kQxCO52WnPLFxLr0Psx2 yetA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=CgJTeRc3rEhlDEBE4rG2ggckP6G8hCW9m6Zu9TqeojM=; b=SND3FtyVUVFxPdb95w1ff/Oah0k8Z3h1h4iau8IeIlmLiLNhZbF5i7RzqwsUCE+CU5 5jb4DvfHk4rYS0M/ZBD31lGAlMSo6H4AwHcAl5BYeCyK0VkPnYhn2kiUTU7eWlxURhoD 16tZsHOdF9MQQW+xOaVA6v2ffWO7r3bly40xf9K2+Xf2FpBqmWYqdIBNToX485F+f9Jk Ktw1yboF86VSfYuENYnb+/BZCFCOqbtwUyIsFVY9HWK7S0QGRvCkprq20M9jdJS7agVy W1b4Q67V5wi1xgW7A4/O6jtDhjUPt3li+hoYKBNS/svMDreWWlxFxuIFwc2mnuzGQrkv wDKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pw+9ejv7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f23si217298oti.283.2020.02.19.09.52.35; Wed, 19 Feb 2020 09:52:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pw+9ejv7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727393AbgBSRwL (ORCPT + 99 others); Wed, 19 Feb 2020 12:52:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:51468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbgBSRwK (ORCPT ); Wed, 19 Feb 2020 12:52:10 -0500 Received: from localhost.localdomain (unknown [194.230.155.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5864A2467D; Wed, 19 Feb 2020 17:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582134729; bh=iR+Ao5saiVxRTvb2au3o6+lrJj/L8pgoUJPaqHXT/tQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pw+9ejv73mhY1CR0G17KZh3Lsqa5fiV0O/7QI6gk9U2PDs9MO3ClU02Y37BTLXByA GN0d182iKI80TD2kQnS9S6hifIyWgmQDeqbf00LTAX3OWcGloRKcgGg2t8jDCWtng+ jSpnBjCv8a/bUDQcIr+HVIMFPZ9vmp1qxH03hhJk= From: Krzysztof Kozlowski To: Richard Henderson , Ivan Kokshaysky , Matt Turner , Alexey Brodkin , Vineet Gupta , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Yoshinori Sato , Rich Felker , Dave Airlie , David Airlie , Daniel Vetter , Ben Skeggs , Mauro Carvalho Chehab , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S. Miller" , Dave Jiang , Jon Mason , Allen Hubbe , "Michael S. Tsirkin" , Jason Wang , Arnd Bergmann , Geert Uytterhoeven , Andrew Morton , Thomas Gleixner , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, virtualization@lists.linux-foundation.org, linux-arch@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation) Date: Wed, 19 Feb 2020 18:50:04 +0100 Message-Id: <20200219175007.13627-7-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200219175007.13627-1-krzk@kernel.org> References: <20200219175007.13627-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among architectures. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Thomas Zimmermann --- Changes since v1: 1. Add Thomas' review. --- drivers/gpu/drm/mgag200/mgag200_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h index aa32aad222c2..6512b3af4fb7 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.h +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h @@ -34,9 +34,9 @@ #define MGAG200FB_CONN_LIMIT 1 -#define RREG8(reg) ioread8(((void __iomem *)mdev->rmmio) + (reg)) +#define RREG8(reg) ioread8(((const void __iomem *)mdev->rmmio) + (reg)) #define WREG8(reg, v) iowrite8(v, ((void __iomem *)mdev->rmmio) + (reg)) -#define RREG32(reg) ioread32(((void __iomem *)mdev->rmmio) + (reg)) +#define RREG32(reg) ioread32(((const void __iomem *)mdev->rmmio) + (reg)) #define WREG32(reg, v) iowrite32(v, ((void __iomem *)mdev->rmmio) + (reg)) #define ATTR_INDEX 0x1fc0 -- 2.17.1