Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp867737ybv; Wed, 19 Feb 2020 10:54:52 -0800 (PST) X-Google-Smtp-Source: APXvYqyvgNvIx/Ah/wfWmQrvacqbT2WuKeHXaUVh2pSfkDIZmCctVoG44BG2URjqD/yHp0xdjFjb X-Received: by 2002:a05:6808:191:: with SMTP id w17mr5372842oic.29.1582138492683; Wed, 19 Feb 2020 10:54:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582138492; cv=none; d=google.com; s=arc-20160816; b=iE8wkxKrnT8bX9hjHnwcLGF/NmbdAM1p1udW8q912aaVgqJfeWm96faGcP8pEXW2Vy z8jFzOxz39OOc55EGkGfZcbdA7mDNVXKGY62AuN76kQIao7+9Q97lZEjFRJKoP6yx7GO rIX0xzByqhVjElaZBqBWB2YOtAREzmPEND/6S57mNqhiXLBeqs1Ywzb6BVMxcyNQ7yKf Uw4Sg8e7GYKq7jrv/A7LkMOEHvU/HzNfZKqHSmWFRlmLmeFdYrGxsyeP0Bh/F7mAOH8s YQY/pfEShqYtzpIyOqj2DAEUYI5nKvTp+byUOVsGlCa7bA3NdiSVUkPdM32g5hgrcc+Y AW4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dkim-signature; bh=/UO6irQAkGyQ/Cqy5oQ7oIcu+pBDHAQ9auYgdZN2lko=; b=hQ1Kp6/Xh0dyeqEn21nha3Z3yAWsoo+i//40/UR98VrKJcbgzl2cDusCEPz+bG0WqL Cu0vEO1/YePeSv3H2d390f/rfmiAPzFxIV7p3Gq71CcYUVLQdNEk0Ec6yVEsHbgJRrz7 KRE1mJp1LZrJCj+8Q2Je5GRjiNx/dAYkNvjjKIMEsFfkpmYUdWsvnS37YqRRz4J+2kUv Q86E6rssJDcee5LK5Pvq5e26O3uuQo0qTobop8SyT0EuF94vBoWDcnxdptn5aSEEub20 f8aylP8M2+dQ5qEKXvEfsdBlY9dK1X3mzlhVHUyunGSIO9eozt2l80kx10C5D3CZJiX9 knCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Y2xUVvOp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si287975otp.11.2020.02.19.10.54.40; Wed, 19 Feb 2020 10:54:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Y2xUVvOp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbgBSSyH (ORCPT + 99 others); Wed, 19 Feb 2020 13:54:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:60142 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726875AbgBSSyG (ORCPT ); Wed, 19 Feb 2020 13:54:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582138444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/UO6irQAkGyQ/Cqy5oQ7oIcu+pBDHAQ9auYgdZN2lko=; b=Y2xUVvOp/9+g+L6qgrG6LDelto9x1PxePkZalsA/WinU035qnNeec/mTPMDQdF0bIP2ply Vox1rIvK3ipT2F4eazW/y0IXjJAFGXUCyqW302LeQO2AfT9K8MLtbMo7MDaZALDrsde34J dr/8NRJprlHM3F8bzSh23GoXeTRkSfY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-dP1tcruoOkKrpZ0JwaNrEw-1; Wed, 19 Feb 2020 13:54:00 -0500 X-MC-Unique: dP1tcruoOkKrpZ0JwaNrEw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCA63107ACC5; Wed, 19 Feb 2020 18:53:58 +0000 (UTC) Received: from gimli.home (ovpn-116-28.phx2.redhat.com [10.3.116.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 92AAC8B561; Wed, 19 Feb 2020 18:53:55 +0000 (UTC) Subject: [PATCH v2 1/7] vfio: Include optional device match in vfio_device_ops callbacks From: Alex Williamson To: kvm@vger.kernel.org Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dev@dpdk.org, mtosatti@redhat.com, thomas@monjalon.net, bluca@debian.org, jerinjacobk@gmail.com, bruce.richardson@intel.com, cohuck@redhat.com Date: Wed, 19 Feb 2020 11:53:55 -0700 Message-ID: <158213843517.17090.8104613366944906538.stgit@gimli.home> In-Reply-To: <158213716959.17090.8399427017403507114.stgit@gimli.home> References: <158213716959.17090.8399427017403507114.stgit@gimli.home> User-Agent: StGit/0.19-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allow bus drivers to provide their own callback to match a device to the user provided string. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 20 ++++++++++++++++---- include/linux/vfio.h | 4 ++++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index c8482624ca34..0bd77d6ea691 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -875,11 +875,23 @@ EXPORT_SYMBOL_GPL(vfio_device_get_from_dev); static struct vfio_device *vfio_device_get_from_name(struct vfio_group *group, char *buf) { - struct vfio_device *it, *device = NULL; + struct vfio_device *it, *device = ERR_PTR(-ENODEV); mutex_lock(&group->device_lock); list_for_each_entry(it, &group->device_list, group_next) { - if (!strcmp(dev_name(it->dev), buf)) { + int ret; + + if (it->ops->match) { + ret = it->ops->match(it->device_data, buf); + if (ret < 0) { + device = ERR_PTR(ret); + break; + } + } else { + ret = !strcmp(dev_name(it->dev), buf); + } + + if (ret) { device = it; vfio_device_get(device); break; @@ -1430,8 +1442,8 @@ static int vfio_group_get_device_fd(struct vfio_group *group, char *buf) return -EPERM; device = vfio_device_get_from_name(group, buf); - if (!device) - return -ENODEV; + if (IS_ERR(device)) + return PTR_ERR(device); ret = device->ops->open(device->device_data); if (ret) { diff --git a/include/linux/vfio.h b/include/linux/vfio.h index e42a711a2800..029694b977f2 100644 --- a/include/linux/vfio.h +++ b/include/linux/vfio.h @@ -26,6 +26,9 @@ * operations documented below * @mmap: Perform mmap(2) on a region of the device file descriptor * @request: Request for the bus driver to release the device + * @match: Optional device name match callback (return: 0 for no-match, >0 for + * match, -errno for abort (ex. match with insufficient or incorrect + * additional args) */ struct vfio_device_ops { char *name; @@ -39,6 +42,7 @@ struct vfio_device_ops { unsigned long arg); int (*mmap)(void *device_data, struct vm_area_struct *vma); void (*request)(void *device_data, unsigned int count); + int (*match)(void *device_data, char *buf); }; extern struct iommu_group *vfio_iommu_group_get(struct device *dev);