Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp873733ybv; Wed, 19 Feb 2020 11:02:27 -0800 (PST) X-Google-Smtp-Source: APXvYqzsLWV68tf7y0Ags/83pegXoHTpu10dD8Q6+kHt5OEoaqqAKotXoEoGzybQr9+256hlCxkB X-Received: by 2002:a05:6830:1042:: with SMTP id b2mr20340856otp.306.1582138947726; Wed, 19 Feb 2020 11:02:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582138947; cv=none; d=google.com; s=arc-20160816; b=lqgRrrTDv62cHuEnOYusQPqG01hhF2gl3sHpKhWkEL1VEHrXy/o0RxJEvruerc6Wpo fAoyLaP5nXo/WnF7tpHJaETDhtyEQ7Z8zJPhh1KtMdFOoPWSNWQbwsIe3VVfOJov4Oqc 5RmJRMiXb6F64yvCaES38C4ZiP466WfuYNq1DGTHLuBLdXWH7Fbcx58Vw7MoN2pw1YZI dbXoDjsOGDtblFc0XTsDs4HnvNdcXnnefFS5WNq6c12RdllJmOPVou02VPtg8XPKHHgy 4xK31ZfHUgGqrdjPsGELtTZcoa/Q9qxuWjxtCA+i7vMZyrf7cMIvo8PPN8pq5bym7hst Rvlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:references:subject:cc:cc:cc :to:from:date:message-id; bh=DQ+8e/HKGBnHq6nvydGmkDGoz7qP42z+/5Gl8Bp1vXM=; b=GrCD5xtl7CtiG6StGEQnLZkcL//MkSlxVf2Uqv717N7lhsDTpfs1d6Dt6nenCYhsdU z5uYO+PKcootmdd2XD27Zs5I51r5qFvlOJZN8GmRr+dWcWTUAgrGJGRHU/LDMK/NhRyG AZghNY3LPKqRNxStOpFfIy7g73w0aiNqZnXiBHsQk3VT0bserfxsHetn4Dyv2gNFQkEU 7n9D5/l1eBpj4cZrv75BF25WWKJXZwgpULpkiyhpWK0pzERQXrpX2mso4cuMDmA4V2Ow iZqgEJpCbllcV/jKXbOYW8ITIugdUFh58zMiia/VpK0qv1HaBrxnoeTGbleWowPNj6pj B1kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x138si1339479oif.142.2020.02.19.11.02.15; Wed, 19 Feb 2020 11:02:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726764AbgBSTCF (ORCPT + 99 others); Wed, 19 Feb 2020 14:02:05 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35983 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726643AbgBSTCE (ORCPT ); Wed, 19 Feb 2020 14:02:04 -0500 Received: by mail-pf1-f194.google.com with SMTP id 185so533021pfv.3; Wed, 19 Feb 2020 11:02:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:to:cc:cc:cc:subject :references:in-reply-to; bh=DQ+8e/HKGBnHq6nvydGmkDGoz7qP42z+/5Gl8Bp1vXM=; b=b6wsWYzz0dLWKsiIXsKzMSA8s/F1kQZcnl/azBTP3uXFetqwGwxg0zi2hINxAlbGG5 AGoGLGmbDDClNOR6h7xL7NuwrYNnP5hptLfCsinZ5TjnmsWvrfZR7MZ4S9dgkfZopV4g uoK7rWn/ypObWivR/uuhDmWQJ2g24SMRt6LJoEAWKA60MBDJ6/BFzlIF1Farkf/PNNd+ 6Rg1reTdDpnRNf6fPPhHrbS8EH36em39rbsNd5bE3zRmmoyUfA8SglrXNhRXYCG9+bv2 KVUDpxhrBVf1NXlCISkG2fPm0LSzTxxvmIvW1JqNSCfxkRo4fx5J4P8uh3i5+ciXxjVo L74A== X-Gm-Message-State: APjAAAU/Ef9dre8PCrisnp+l7Eu6CReMAdJaxShl/5Cl7yNwTCLwQckb tLrpPVYkYOuZIJuYQRDvzuA= X-Received: by 2002:a63:2254:: with SMTP id t20mr29921645pgm.423.1582138923106; Wed, 19 Feb 2020 11:02:03 -0800 (PST) Received: from localhost ([2601:646:8a00:9810:5af3:56d9:f882:39d4]) by smtp.gmail.com with ESMTPSA id o16sm437367pgl.58.2020.02.19.11.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 11:02:02 -0800 (PST) Message-ID: <5e4d862a.1c69fb81.5dc73.17b5@mx.google.com> Date: Wed, 19 Feb 2020 11:01:56 -0800 From: Paul Burton To: =?utf-8?b?5ZGo55Cw5p2wIChaaG91IFlhbmppZSk=?= CC: linux-mips@vger.kernel.org CC: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, paul@crapouillou.net, robh+dt@kernel.org, mark.rutland@arm.com, ralf@linux-mips.org, paulburton@kernel.org, sernia.zhou@foxmail.com, zhenwenjin@gmail.com, dongsheng.qiu@ingenic.com CC: linux-mips@vger.kernel.org Subject: Re: [PATCH] MIPS: X1000: Fix clock of watchdog node. References: <1581855028-25552-3-git-send-email-zhouyanjie@wanyeetech.com> In-Reply-To: <1581855028-25552-3-git-send-email-zhouyanjie@wanyeetech.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, 周琰杰 (Zhou Yanjie) wrote: > The devicetree ABI was broken on purpose by commit 6d532143c915 > ("watchdog: jz4740: Use regmap provided by TCU driver"), and > commit 1d9c30745455 ("watchdog: jz4740: Use WDT clock provided > by TCU driver"). The commit message of the latter explains why the ABI > was broken. > > However, the current devicetree files were not updated to the new ABI > described in Documentation/devicetree/bindings/timer/ingenic,tcu.txt, > so the watchdog driver would not probe. > > Fix this problem by updating the clock of watchdog node from > "&cgu X1000_CLK_RTCLK" to "&tcu TCU_CLK_WDT" to comply with the new > ABI. > > Fixes: 7a16ccd300c2 ("[v8,1/4] MIPS: Ingenic: Add Ingenic X1000 > support."). Applied to mips-fixes. > commit eb41113870c9 > https://git.kernel.org/mips/c/eb41113870c9 > > Fixes: 7a16ccd300c2 ("[v8,1/4] MIPS: Ingenic: Add Ingenic X1000 support."). > Signed-off-by: 周琰杰 (Zhou Yanjie) > Signed-off-by: Paul Burton Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paulburton@kernel.org to report it. ]