Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp895607ybv; Wed, 19 Feb 2020 11:27:29 -0800 (PST) X-Google-Smtp-Source: APXvYqyyldqIm6MrjwQY1gXhNQO6CBBLfksFBinGJ1xyTNJ9TzhX9QPWdd22A6cxWWS2v2UsCPDf X-Received: by 2002:a9d:7b4e:: with SMTP id f14mr20832838oto.355.1582140448935; Wed, 19 Feb 2020 11:27:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582140448; cv=none; d=google.com; s=arc-20160816; b=pBHsE1pG8H2D0BNdwJaXmmEV3zS69KtpDU0ulqY+iLXEgjypqSROjpQcyEV1pwBQcg HqDwfByi3FmizNBT7Cdtn+S611j+hQ6o0DEXfirXg9O1IXgTu3WbQ1JyGYCSlMS0HVfo qM63oQtenrcIiSLbQqrjexThxsCw81Xz/H8kRQkzdtjSbxEQGPfZch+ktVy82fV+rGCY E2TgUUNz+FZ2B1nLSQduJoTP143bR916RXVezXNHQAkG8KmP+qCdG2edOpBwFC21Gibm RhgXrnAQV5sfmJ4PJXqDlctDcEqZchxnwS+5Wi4vfCQCqW4zqE34zJyiQc7TBXAc4R+/ CkDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Yc4u2FNt1IF2IbHtsIBwT/EjGq6IDcKxgr96tmofLT0=; b=cweMExyxWt2EhmTchWzEeod5eHKR7UyfG/P0/Ey/gIMvcbQnJ/qoN33k34BC5JZfGn eZmEzCjAAxhb+Z1U7TyBfxWagGpTqTqpQjPEGS6m2xYshl2fYMcLyLKduMMJxjL+2K05 F5RqNiXh9xvERhegqiNN9iTb6cdloqRyUnrr7TlUEujj+2e6RW+A0bImOPFvHjFHpI5w UC2V7jSHhnIK5sOBAlTXppqBRxyViRwcnoobAOLSOtHcMr9Ifx5CErVs42ae/w18xFry 6xrVBiRwTkT6t02U7LBngm4FVNOuOgzEB557VczTzELuiNtk7FrEBhH8MejEhy7ZSFGj retA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uuO8ONaw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f23si346486oti.283.2020.02.19.11.27.17; Wed, 19 Feb 2020 11:27:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uuO8ONaw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbgBST0y (ORCPT + 99 others); Wed, 19 Feb 2020 14:26:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:46558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbgBST0y (ORCPT ); Wed, 19 Feb 2020 14:26:54 -0500 Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09525208E4; Wed, 19 Feb 2020 19:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582140414; bh=Yc4u2FNt1IF2IbHtsIBwT/EjGq6IDcKxgr96tmofLT0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uuO8ONawyjT+YQsnSh9q7TNz5MXsxAChG8Jkavgb1IBkTn6/nlCiavADJp69yj4uH Q+hOztkuyRvzY7JZQcWs5x2xWSd9ckOLENn2Kme+eE4juIf23dHrA3g1XPIBd4Asjw WSHuBCjriM/qQ5bLTjugv90KBVY6t7QA5HNLpseA= Date: Wed, 19 Feb 2020 11:26:53 -0800 From: Andrew Morton To: Sultan Alsawaf Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Stop kswapd early when nothing's waiting for it to free pages Message-Id: <20200219112653.116de9db314dade1f6086696@linux-foundation.org> In-Reply-To: <20200219182522.1960-1-sultan@kerneltoast.com> References: <20200219182522.1960-1-sultan@kerneltoast.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Feb 2020 10:25:22 -0800 Sultan Alsawaf wrote: > Keeping kswapd running when all the failed allocations that invoked it > are satisfied incurs a high overhead due to unnecessary page eviction > and writeback, as well as spurious VM pressure events to various > registered shrinkers. When kswapd doesn't need to work to make an > allocation succeed anymore, stop it prematurely to save resources. Seems sensible. Please fully describe the userspace-visible runtime effects of this change?