Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp938040ybv; Wed, 19 Feb 2020 12:19:41 -0800 (PST) X-Google-Smtp-Source: APXvYqyaDLFfsFJvmEHJ7vyrzNMI1xoeE6v9ffcB8nk7qBHHUJ1W4ue2gNaxYNbTXtw6amADJioc X-Received: by 2002:aca:fc0c:: with SMTP id a12mr5574835oii.118.1582143580828; Wed, 19 Feb 2020 12:19:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582143580; cv=none; d=google.com; s=arc-20160816; b=M0wzXoT8wcOy44g0B+HAmc+DkXOJnvbYd5cKDzBAVL08rcSrUu43FY8/HDO1W+0xIq g/wgXlQ0x69ahyoE4vCmpkGMrmSYX7032voDHbaUPKkPmUQEnl2bTGhNXcUviPLj+tUF 4JzbmWw3JhASoGoBkqM7dIqlzy6bo2Kx9ojBNImFrlGAxOJHh1OOlDvVbh/3H96cYQHJ NBGGqI95YtMfAQIz5UywHaNBcAKNUwVCv4VJ1tSk2zXHpOVrWv/cSyhS8+EjE7xCoSxa NeSUxE1d6zm02FltGKP9BHUkPn2ethTEXm4GZrofZPD6KllzXUV1XTtj/Q30cvzub4xI bByQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7os/M8IuBkAA3/9g8Hoqx409nZEI7AZx5Cfmo/opAFk=; b=zdz6nqDAwO7YUtHO0BXcxJ4/CxJqpGff0NrlqMSRhfE6FQOSWf7SHfICY4Wwoy4PKK EpDUYMqhY//2P5uAtRCkaxqXpTd5tsEpspkjRBBtTIpNWXRRy2s2jFaxMfD5tO5oQLP9 N5BCjoaIprCqHXRKBFbJt6kkLcq/2GOQRMEV+89da70WwYizEX3wwhdMdWWG2nLk+39J Q/I4Z0hd++sDF3QUCymfMkzMpmpBhvwoK7p8jRVApD8rG+FnbOiF10cbQjeniYsqi3bO hAjEJ8Jw35QHdZYQtqGWdJXBPrM/bcKV/58gFosHAQx1W/UjdmKd/+9DwPNW8nxIs/FW Rxcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CRtbjXZ8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7si416242otr.183.2020.02.19.12.19.27; Wed, 19 Feb 2020 12:19:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CRtbjXZ8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726793AbgBSUTR (ORCPT + 99 others); Wed, 19 Feb 2020 15:19:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:49180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgBSUTR (ORCPT ); Wed, 19 Feb 2020 15:19:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B33B24654; Wed, 19 Feb 2020 20:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582143556; bh=BMqfNAqnRNhsX0S28jKzbbqRGrFmcgyFHV69yPDrYEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CRtbjXZ8Mde4Hy9lBcGW6R/EQrCVPybzx/AtGRwcTkhkv5laP25wPQKXxxwV1Cg+S yjejy+XDrUgNWBiBORk6oD9t64KlnmFe5OwOsPlxIVajPCExoZilujW9pESEso0GUr /y/4/IY9PY5rW2aup4tbdCgdRqPcec7EmCYg9ov0= Date: Wed, 19 Feb 2020 21:19:13 +0100 From: Greg Kroah-Hartman To: Kaaira Gupta Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: match parenthesis alignment Message-ID: <20200219201913.GA2882443@kroah.com> References: <20200219195651.GA485@kaaira-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219195651.GA485@kaaira-HP-Pavilion-Notebook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote: > Fix checkpatch.pl warning of alignment should match open parenthesis in > audio_codec.c > > Signed-off-by: Kaaira Gupta > --- > drivers/staging/greybus/audio_codec.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c > index 08746c85dea6..d62f91f4e9a2 100644 > --- a/drivers/staging/greybus/audio_codec.c > +++ b/drivers/staging/greybus/audio_codec.c > @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec, > i2s_port = 0; /* fixed for now */ > cportid = data->connection->hd_cport_id; > ret = gb_audio_apbridgea_register_cport(data->connection, > - i2s_port, cportid, > + i2s_port, cportid, > AUDIO_APBRIDGEA_DIRECTION_TX); You can't do it for one line, and not all of the lines. And if you do it for all lines, then you push past the line-length. So you are back to what we currently have, which is the best we can do, sorry. greg k-h