Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp941801ybv; Wed, 19 Feb 2020 12:24:51 -0800 (PST) X-Google-Smtp-Source: APXvYqyVMY3+GM9nU1FLDvhPxeUnfBEl6dDRQwvBkQFyEpFM7FLZMO+uElkYz8Y5Y0EkUrOURfMz X-Received: by 2002:aca:c551:: with SMTP id v78mr5847771oif.161.1582143891757; Wed, 19 Feb 2020 12:24:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582143891; cv=none; d=google.com; s=arc-20160816; b=W1Ff163vG8dzZouXAEctCkQLgbuub5qdkHsAdwTC5KfJ2q54FvUEwfs55zLEf1pEGf WFQhsv5yXAAyOPFHEWiDimXZSiDaF4+ReOtQoF8xaIis4jBlVHyvng0/htNdi6NAJcBc zKACF2DXNCpmWNPRvyofq0PDkomvpZMsv9qn1YiU2ZvNoaEu7RY757rdlXUkzxdiHTHN QkTRCEKkH3ShMaXLDSEqiZtVKve9+QqJeSHYEsmeLcIa/snY2OkrM3j6sYnjF9wYC0zk r3G4Z1LVEQKmnyKzb6A1vdxBUjLDfLMiT9N2e4fV3uQHWiY2IGdGv2Z+3fJvO0URn7iz oNsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Stnn+zSSGNCFbZ988J4GuiCkm17Qbq44jVcYhuJTWJc=; b=EJPgQU8zvOxa5FaLo+iNlQ0wK807XXiGBkmAH3hyPqs1N1gqCBMExAvTLjHUraw7Yi 2TsAwbixQajVdp2vWllhviKHsIi9GlEahOIZVhYhRjq81C60jNT8mJZq2dBAv1hBKN3y YXhJGVLuEwSYR9NcqCoe9NGaEOZMVFyaF7Zp52TrqVycxJbru+xDEEtyMDhDqRfWr0xO AbhkBwkf50zgLEzWlaXZOqWurOGICKxENijOH7fqznhkqFN7xJ/mcszYGK5X8s9RESXT k2otjytVwAPS4W6M3zOYOcy28MECDdO6Wn4ZiXe4IGz9E/DmMqYxFcliQZ//yzaqIxrh Whhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=PoUTRdSy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s15si10077095oih.252.2020.02.19.12.24.39; Wed, 19 Feb 2020 12:24:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=PoUTRdSy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726996AbgBSUY2 (ORCPT + 99 others); Wed, 19 Feb 2020 15:24:28 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:3914 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgBSUY2 (ORCPT ); Wed, 19 Feb 2020 15:24:28 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 19 Feb 2020 12:23:16 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 19 Feb 2020 12:24:27 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 19 Feb 2020 12:24:27 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Feb 2020 20:24:27 +0000 Subject: Re: [PATCH v6 07/19] mm: Put readahead pages in cache earlier To: Matthew Wilcox , Christoph Hellwig CC: , , , , , , , , , References: <20200217184613.19668-1-willy@infradead.org> <20200217184613.19668-12-willy@infradead.org> <20200219144117.GP24185@bombadil.infradead.org> <20200219145246.GA29869@infradead.org> <20200219150103.GQ24185@bombadil.infradead.org> From: John Hubbard X-Nvconfidentiality: public Message-ID: Date: Wed, 19 Feb 2020 12:24:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200219150103.GQ24185@bombadil.infradead.org> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582143796; bh=Stnn+zSSGNCFbZ988J4GuiCkm17Qbq44jVcYhuJTWJc=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=PoUTRdSyZJ3hX2dxzQISosJ/wVYoveMKl+7atg1sDrOWdAAaYMtdVxq7QyYHhh7xe EvTmBI7/rq4HLGscXS8LPXNBnQ1Jix4flhNHGsxk201kSI8sMpgUmQGRpk7I9BpUhS +KjQiwXIyu9koQoSyGAly8ElawI2qpwAoJWQDFM4pVRo/Z9yKmG/dGB+jg0mlia4Y2 aAY4dZzfwP+DRcHOuBWJl3IdIgHWxdpwgzTmZEfGVW+WOZbqKq5bU129bePvvI5bU1 dYKswZNLebiNLPAg01grHG4u36LomMBF2QsjP/hPLPNASaXyUhQMXbUJhq2V3Ktwp6 cwNUY5UNidflg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/19/20 7:01 AM, Matthew Wilcox wrote: > On Wed, Feb 19, 2020 at 06:52:46AM -0800, Christoph Hellwig wrote: >> On Wed, Feb 19, 2020 at 06:41:17AM -0800, Matthew Wilcox wrote: >>> #define readahead_for_each(rac, page) \ >>> while ((page = readahead_page(rac))) >>> >>> No more readahead_next() to forget to add to filesystems which don't use >>> the readahead_for_each() iterator. Ahem. Yes, this looks very clean. And less error-prone, which I definitely appreciate too. :) >> >> And then kill readahead_for_each and open code the above to make it >> even more obvious? > > Makes sense. > Great! thanks, -- John Hubbard NVIDIA