Date: Thu, 9 Feb 2006 20:55:59 -0800
From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: kernel@kolivas.org, linux-mm@kvack.org, ck@vds.kolivas.org, pj@sgi.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Implement Swap Prefetching v23
Message-Id: <20060209205559.409c0290.akpm@osdl.org>
In-Reply-To: <43EC1A85.2000001@yahoo.com.au>
References: <200602101355.41421.kernel@kolivas.org>
	<200602101449.59486.kernel@kolivas.org>
	<43EC1164.4000605@yahoo.com.au>
	<200602101514.40140.kernel@kolivas.org>
	<20060209202507.26f66be0.akpm@osdl.org>
	<43EC1A85.2000001@yahoo.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1072
Lines: 32

Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> Andrew Morton wrote:
> > Con Kolivas <kernel@kolivas.org> wrote:
> > 
> >> Ok I see. We don't have a way to add to the tail of that list though?
> > 
> > 
> > del_page_from_lru() + (new) add_page_to_inactive_list_tail().
> > 
> > 
> >>Is that 
> >> a worthwhile addition to this (ever growing) project? That would definitely 
> >> have an impact on the other code if not all done within swap_prefetch.c.. 
> >> which would also be quite a large open coded something.
> > 
> > 
> > Do both of the above in a new function in swap.c.
> > 
> 
> That'll require the caller to do lru locking.
> 
> I'd add an lru_cache_add_tail, use it instead of the current lru_cache_add
> that Con's got now, and just implement it in a simple manner, without
> pagevecs.

umm, that's what I said ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/