Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1047724ybv; Wed, 19 Feb 2020 14:54:22 -0800 (PST) X-Google-Smtp-Source: APXvYqzjjaJnZYyYzuG5w6jAVJY/i8BIAPZIjp8Uuvq17dFSArCTI//z14zFIDVtzq0lGd7/c6VN X-Received: by 2002:a05:6808:319:: with SMTP id i25mr18150oie.128.1582152862424; Wed, 19 Feb 2020 14:54:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582152862; cv=none; d=google.com; s=arc-20160816; b=HOXpK30h/KWUnIqMPktMiwdoXerzAr0ZCV6qttYyxG1w6H4pb90Zc78CpSsC6EZBBQ aQ24iuCAt3g1NwY0hZNKHtZWRm+dUD3nOX2wIw5TbiV/a6G9ngbAF+pZap0NNRNcuoCZ vOtxnxFUkC7fu1sZpbFDT9LDWmEGxMfdJs8Y/0D111LB/NYlz5ut6RlwKLH9Pb+Rxc15 YKm05H+iMmlWYaD9v3ULrZwNMBfYcNOhYtEaUYCCC/WhhcvoODZdX2mV/fPo0TTeMf8w VzkQMJ7aHNQqwHTgSlXHd1wyYbgachIXojba8QSiorNEeXf9NQw2MKdJ+lGfHZ9tdmLI 4OBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=AcediiSivT+LWqDEtOSOEIb/ql/h3th0iLtIJJddY0A=; b=cuyLzkvBL4A7JDf9rlJFMBjKTh6cLZM8F61XyVNl3SWN7vjTPiteA71O38hJFZcLZi dpSdGnzpfdX0UnQwsFXx4BIC8fz8AY5SyILjXWPTnKlXD+hHalhQwgRcVI9SluyTormp L12zHXpQ/xnBdDsefll3hpAAoPUyyy0+ZE+i0oSbc1DSxv/lZdHQ1U9bOziwDtwrzC7Z C93hTEixnkD1r11cCOZfYx16LLySYnGW433m+9LhehnCxrRFVT2vvm/pPcdI7eWDtVjt 8dfRNQZY/UuAcGvNvfEFMGwBZhlSFBgBZ+ZJUz1mlMuZCOoDsZ201bPWGY4CKbkRCibd Rhfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=BCbh2aaO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g26si596306otk.324.2020.02.19.14.54.08; Wed, 19 Feb 2020 14:54:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=BCbh2aaO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727855AbgBSWxa (ORCPT + 99 others); Wed, 19 Feb 2020 17:53:30 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:37385 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727429AbgBSWx3 (ORCPT ); Wed, 19 Feb 2020 17:53:29 -0500 Received: by mail-pg1-f193.google.com with SMTP id z12so862193pgl.4 for ; Wed, 19 Feb 2020 14:53:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=AcediiSivT+LWqDEtOSOEIb/ql/h3th0iLtIJJddY0A=; b=BCbh2aaODXUOMbJ47FYF0Z3q9D7rmjUO9/HBZ51aFQnoqI+xQZNeZTl4dktydUcZO5 mfuB+gNhVU3QidqaXo1cEkR9P6QUPcTUycelJSZTKfXGbYQhspJ+EvcjDHoXBiGZuk9q e9xQE32LTHEKzSITdQuKrTMmihiSSub4Q4KM0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=AcediiSivT+LWqDEtOSOEIb/ql/h3th0iLtIJJddY0A=; b=hddDCO3PZxfKa3Lerah77KlS7c8beD1BfCa1OpqjOX7iy9sH0882mhOjUME5CFgbVW nCwvyPiDh7S2UHZjxz7OMshAB75cy2j+gfkA6WlQfCjxuqAep319TgI7XvBXCnw1S3Wv 8byQopX3Dy/A5HHInSZGD+0cLT7ZQ6YhfairD+O/QyaOloFjzEDdzB5kJvAhz1iDgUo7 TArBvJqGNDxTd8UL/gADA0RDdJ8zaKjtiIESzmjOCwry2gMDKcTCGfdzUumy/UKrXC+1 nQTytdQ64cOzS2va4FLu8bllV2fj4VdvJpAt6OpI/pdq+S2+3hfa2y6kITUBnLNc3yxf q8yw== X-Gm-Message-State: APjAAAWxxAPPX039Ouhy1No6kfDbWSJ5lv5IZQPptQRpb2dPpy3NWkjP fvI/bvKNaOhBJQvHX13LtO305Q== X-Received: by 2002:a63:c30e:: with SMTP id c14mr31594137pgd.168.1582152807989; Wed, 19 Feb 2020 14:53:27 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id h3sm845289pjs.0.2020.02.19.14.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 14:53:27 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <6f95b3f0d39433c7e6b01094bdb200a7ac8e9f0d.1582048155.git.amit.kucheria@linaro.org> References: <6f95b3f0d39433c7e6b01094bdb200a7ac8e9f0d.1582048155.git.amit.kucheria@linaro.org> Subject: Re: [PATCH v5 3/8] drivers: thermal: tsens: use simpler variables From: Stephen Boyd Cc: Amit Kucheria , linux-pm@vger.kernel.org To: Amit Kucheria , Andy Gross , bjorn.andersson@linaro.org, daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, sivaa@codeaurora.org Date: Wed, 19 Feb 2020 14:53:26 -0800 Message-ID: <158215280660.184098.15487361696633323314@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Amit Kucheria (2020-02-18 10:12:07) > We already dereference the sensor and save it into a variable. Use the > variable directly to make the code easier to read. >=20 > Signed-off-by: Amit Kucheria > Reviewed-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd