Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <158215745745.386537.12978619503606431141.stgit@warthog.procyon.org.uk>
In-Reply-To: <158215745745.386537.12978619503606431141.stgit@warthog.procyon.org.uk>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 19 Feb 2020 17:21:33 -0800
Message-ID: <CAHk-=whOAg2EJycA=x=8RzBy3dnDFsgnyxrjREyNu6-8+eTTHA@mail.gmail.com>
Subject: Re: [RFC PATCH] afs: Create a mountpoint through symlink() and remove
 through rmdir()
To:     David Howells <dhowells@redhat.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, linux-afs@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 19, 2020 at 4:11 PM David Howells <dhowells@redhat.com> wrote:
>
> If symlink() is given a magic prefix in the target string, turn it into a
> mountpoint instead.
>
> The prefix is "//_afs3_mount:".

That sounds sane.

Your argument that if the prefix is made really long it couldn't be a
valid symlink at all on AFS is fair, but seems somewhat excessive.

The only issue I see with this interface is that you can now create
these kinds of things by untarring a tar-ball etc.

I can see that being both very convenient and a possible security
pain. But I'm assuming that the real security is on the server side
anyway and not just anybody can create arbitrary things like these?

         Linus