Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 06/10] ASoC: tegra: add Tegra186 based DSPK driver
To:     Sameer Pujar <spujar@nvidia.com>, perex@perex.cz, tiwai@suse.com,
        robh+dt@kernel.org
Cc:     broonie@kernel.org, lgirdwood@gmail.com, thierry.reding@gmail.com,
        jonathanh@nvidia.com, digetx@gmail.com,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com,
        rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com
References: <1582180492-25297-1-git-send-email-spujar@nvidia.com>
 <1582180492-25297-7-git-send-email-spujar@nvidia.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <6f8d0b45-025e-e03f-7478-c4c08bf61cbb@infradead.org>
Date:   Wed, 19 Feb 2020 22:53:52 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <1582180492-25297-7-git-send-email-spujar@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/19/20 10:34 PM, Sameer Pujar wrote:
> diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> index 0c07f63..fb77df3 100644
> --- a/sound/soc/tegra/Kconfig
> +++ b/sound/soc/tegra/Kconfig
> @@ -93,6 +93,19 @@ config SND_SOC_TEGRA210_I2S
>            compatible devices.
>            Say Y or M if you want to add support for Tegra210 I2S module.
>  
> +config SND_SOC_TEGRA186_DSPK
> +        tristate "Tegra186 DSPK module"
> +        depends on SND_SOC_TEGRA
> +        help
> +          Config to enable the Digital Speaker Controller (DSPK) which
> +          converts the multi-bit Pulse Code Modulation (PCM) audio input to
> +          oversampled 1-bit Pulse Desnity Modulation (PDM) output. From the

                                     Density

> +          signal flow perspective DSPK can be viewed as a PDM transmitter
> +          that up-samples the input to the desired sampling rate by
> +          interpolation and then converts the oversampled PCM input to
> +          the desired 1-bit output via Delta Sigma Modulation (DSM).
> +          Say Y or M if you want to add support for Tegra186 DSPK module.

Please fix indentation according to coding style.
Thanks.

> +
>  config SND_SOC_TEGRA_RT5640
>  	tristate "SoC Audio support for Tegra boards using an RT5640 codec"
>  	depends on SND_SOC_TEGRA && I2C && GPIOLIB


-- 
~Randy