Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 07/10] ASoC: tegra: add Tegra210 based ADMAIF driver
To:     Sameer Pujar <spujar@nvidia.com>, perex@perex.cz, tiwai@suse.com,
        robh+dt@kernel.org
Cc:     broonie@kernel.org, lgirdwood@gmail.com, thierry.reding@gmail.com,
        jonathanh@nvidia.com, digetx@gmail.com,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com,
        rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com
References: <1582180492-25297-1-git-send-email-spujar@nvidia.com>
 <1582180492-25297-8-git-send-email-spujar@nvidia.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <c1871939-ebf9-150e-1786-96a7f6bd6522@infradead.org>
Date:   Wed, 19 Feb 2020 22:55:21 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <1582180492-25297-8-git-send-email-spujar@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/19/20 10:34 PM, Sameer Pujar wrote:
> diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> index fb77df3..c0a5f0b 100644
> --- a/sound/soc/tegra/Kconfig
> +++ b/sound/soc/tegra/Kconfig
> @@ -106,6 +106,18 @@ config SND_SOC_TEGRA186_DSPK
>            the desired 1-bit output via Delta Sigma Modulation (DSM).
>            Say Y or M if you want to add support for Tegra186 DSPK module.
>  
> +config SND_SOC_TEGRA210_ADMAIF
> +        tristate "Tegra210 ADMAIF module"
> +        depends on SND_SOC_TEGRA
> +        help
> +          Config to enable ADMAIF which is the interface between ADMA and
> +          Audio Hub (AHUB). Each ADMA channel that sends/receives data to/
> +          from AHUB must interface through an ADMAIF channel. ADMA channel
> +          sending data to AHUB pairs with an ADMAIF Tx channel, where as
> +          ADMA channel receiving data from AHUB pairs with an ADMAIF Rx
> +          channel. Buffer size is confiigurable for each ADMAIIF channel.

                                     configurable

> +          Say Y or M if you want to add support for Tegra210 ADMAIF module.

Please fix indentation according to coding style.

> +
>  config SND_SOC_TEGRA_RT5640
>  	tristate "SoC Audio support for Tegra boards using an RT5640 codec"
>  	depends on SND_SOC_TEGRA && I2C && GPIOLIB


-- 
~Randy