Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp389259ybv; Thu, 20 Feb 2020 00:00:41 -0800 (PST) X-Google-Smtp-Source: APXvYqw2SrP+ZIiSeDttjZTyqo/gMd626FX4HAOzb7tMSTisCqjTl7HX9mROtYuM7Oi0jXNdCWNO X-Received: by 2002:a05:6830:1014:: with SMTP id a20mr9188038otp.302.1582185641724; Thu, 20 Feb 2020 00:00:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582185641; cv=none; d=google.com; s=arc-20160816; b=Op5B89QwC+pd7gQ4Yhkf7IwB+6W6XhYURzU7/qX/TbPKgbM02ggVOu+rjYfQmtjJuO C5fsWncwKL5gyjYp4Bvawurv61i/Pu3Q49qBeyMkEFCDGBWimBsB/u/PyVwpElT1FOuV sxvapaxfwoJUkuVB3NHHzt9txuOQRJUiNlj31/KYyrOkYZXd447Qbz2lzAK0GeOzKhbp 3nVIm8/nj37rl83XN/aSloUi5YY/UWngNT9JvQMGm+E5xgX8QTwu8V6Eyvf02C+9i4tn W1oVhbm19GYYyWDN1JWkqAlHqwW7HD1rAbab80n+YXC5eApKDLw0Vmp+8A/wCzM+yRk+ Fc/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=5DLUvvgB9n0liAekBwuVjvbB+qCG2/jQSAzR9FuBhnU=; b=Aru6UqrF3In9VWTrTGC8r7WnbQp/VCZQZ+g4RJ2I7ButVqc+7Jz8JZAewr2Hi/fKzw ML1OsIg4QfRSuCo0sgxYJZicmU7IJcrJYObgoBWr4X2I2u1rNMhvGF9tcs+uebG1e2Cu PDKvf3n+TGKOqah0zgL0gGxvz9BNf/HD6YR35HvUvvFYn0V9FSUuMc0hycdrSCrN7CWZ zWPcEirBGWYjVa4BHrFfbbAZ2PUOGQ1B+ct7YEFRfjDU3asjGjK33A7Qf0mASkF+S3TJ YhC5e9gVAialchd3lNWi9aqe9GpFF3Yw7dfU+c6c4VCbMNc1eBB9FNPdraCSz5hIQF4t OhPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v23si1226552oto.81.2020.02.20.00.00.28; Thu, 20 Feb 2020 00:00:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbgBTH7H convert rfc822-to-8bit (ORCPT + 99 others); Thu, 20 Feb 2020 02:59:07 -0500 Received: from mail.fireflyinternet.com ([77.68.26.236]:58201 "EHLO fireflyinternet.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726783AbgBTH7H (ORCPT ); Thu, 20 Feb 2020 02:59:07 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20283602-1500050 for multiple; Thu, 20 Feb 2020 07:59:01 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Alex Deucher , paulmck@kernel.org From: Chris Wilson In-Reply-To: Cc: Dave Airlie , LKML , Maling list - DRI developers References: <20200220004232.GA28048@paulmck-ThinkPad-P72> Message-ID: <158218553821.8112.10047864129562395990@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: drm_dp_mst_topology.c and old compilers Date: Thu, 20 Feb 2020 07:58:58 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Alex Deucher (2020-02-20 02:52:32) > On Wed, Feb 19, 2020 at 7:42 PM Paul E. McKenney wrote: > > > > Hello! > > > > A box with GCC 4.8.3 compiler didn't like drm_dp_mst_topology.c. The > > following (lightly tested) patch makes it happy and seems OK for newer > > compilers as well. > > > > Is this of interest? > > How about a memset instead? That should be consistent across compilers. The kernel has adopted the gccism: struct drm_dp_desc desc = {}; git grep '= {}' | wc -l: 2046 git grep '= { }' | wc -l: 694 -Chris