Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp403905ybv; Thu, 20 Feb 2020 00:18:32 -0800 (PST) X-Google-Smtp-Source: APXvYqxxuyBE+eF27eBkj6u2N35bpMXxr3s3Uf79gXrG22YBxt/nqbkg62WGrGt+Jm3rSEhfIyst X-Received: by 2002:a54:410e:: with SMTP id l14mr1151089oic.42.1582186712031; Thu, 20 Feb 2020 00:18:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582186712; cv=none; d=google.com; s=arc-20160816; b=tIgUqK+VZPRffy0qvzt8dKHUF1BFjHNa3UTdsXUDZQYN3UM1ltcBKm0XdFiRFsIedu rj+u7NODUrfaRm2tLXbumox6KXIxXai1Xbop/8vyR1pYSufFQ0U33Nt52P1SYGQK2pjC ENAHGNq5BbOscve1nbAriYduiHJLN5pNzCyRKcq3mbAqXwV1OuNlYDJTvqza1bm86TeU RQzzWF4YuV/i45g7O4rG8uG5pJWXY6xt6BrlKsARMGQTZw3hXS3xWtDp5uFGlJOb1dyD J98YlkvYAZ5n116GlSzP1NndkEk2MPmx5+Gh+jpc/L8jtbpoEr8fRgjhPbE2/AT1a+Sg LZJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=0RZP5HeD2JzEiptUQXN7t8DlIqi0RXqHsmoaSJOcc6Y=; b=Tv1L3xbIgxj3vXHIogCbOtrw+q+oKR7cJWP8QURZ080U8EXP/ybXgE1hWMHuJSe6/F Ilk2TTg36IQ2oJlzycIMAaIrRZOL6JQzRK89rcLwQ61OCiCN5dKrNyBZEM6b6crYjn9z IpdON7lIag4TFQxQP7BXQnZk2VztHhUf+4lOVhzoBP62xhcmeHRHD1KzOhxWbiQ4dn9X LEXDmAxsbpnYFuLfvtzxJ5ejt8PHEgObnfU0XSQ81L/iWFnsQORqyCJykDJwsx92Bd0t LqKI9rukZD0f/V/bK/vS+bhTfhCSbe1ZV/LDXRBPw3B904JHChGyVykpkw5PuXbxYNvC e5Fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si1325804ote.72.2020.02.20.00.18.19; Thu, 20 Feb 2020 00:18:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726934AbgBTISI convert rfc822-to-8bit (ORCPT + 99 others); Thu, 20 Feb 2020 03:18:08 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:3018 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726501AbgBTISI (ORCPT ); Thu, 20 Feb 2020 03:18:08 -0500 Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id 5EBDE75DE2C3B4178073; Thu, 20 Feb 2020 16:18:04 +0800 (CST) Received: from dggeme701-chm.china.huawei.com (10.1.199.97) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 16:18:03 +0800 Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme701-chm.china.huawei.com (10.1.199.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 20 Feb 2020 16:18:03 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1713.004; Thu, 20 Feb 2020 16:18:03 +0800 From: linmiaohe To: Li RongQing , "pbonzini@redhat.com" , "vkuznets@redhat.com" CC: Liran Alon , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH][resend] KVM: fix error handling in svm_cpu_init Thread-Topic: [PATCH][resend] KVM: fix error handling in svm_cpu_init Thread-Index: AdXnxCuvQCn2ngYdSyKWLfuyXd13zw== Date: Thu, 20 Feb 2020 08:18:03 +0000 Message-ID: <4cf5d767b570430a9e0b515a9d6d8fbd@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.221.158] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Li RongQing writes: > >sd->save_area should be freed in error path > >Fixes: 70cd94e60c733 ("KVM: SVM: VMRUN should use associated ASID when SEV is enabled") >Signed-off-by: Li RongQing >Reviewed-by: Brijesh Singh >Reviewed-by: Vitaly Kuznetsov >--- > arch/x86/kvm/svm.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Oh, it's strange. This is already fixed in my previous patch : [PATCH v2] KVM: SVM: Fix potential memory leak in svm_cpu_init(). And Vitaly and Liran gave me Reviewed-by tags and Paolo queued it one month ago. But I can't found it in master or queue branch. There might be something wrong. :(