Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp418504ybv; Thu, 20 Feb 2020 00:38:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyb316QkkJ/Q02fU7VMzJnwkK/68CbQrP+5pCOho+DjChdmM13s5bKgL6VoeJubJbOnSJXi X-Received: by 2002:aca:5ad5:: with SMTP id o204mr1162158oib.2.1582187881985; Thu, 20 Feb 2020 00:38:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582187881; cv=none; d=google.com; s=arc-20160816; b=rEtzZRfj9ra5BnrFCZgHf9xtCPEaP4MhQ0hMaPFtl7nrJTRMPbIMFW16l3nP2A+g9w F2HTamX0JIjsFuW6ayAF0TTe21QroC2l2z0/S4DVUHRFmzpnCQRNaHw/IiZKSwKKwsMX jHEwP6ZyxPDq0CzsMPJW8d9aC3/5SiDwjir/sdEMvWIVkW0DvSDwfsfBy7NDiEY+lRj9 J0AcTo3MTgGsA16RWVMFPeiNtZW3i4Y7xOvbk0YyP0qxZpzVSesmcY40pHjVBv/OpD5+ +U+IK+Y7WLedIHHojFy83IJCCzfEKqTtfu0g8jb5V6yk7LZDzOrx2qtzSShn3Q8hhdrM 2ENQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wYQONlA9lvcFld0G+NwhV5rBbyIu6fNUKkg/bhapB14=; b=uQDv3mYQc8SDqRbKIZnOeENMgCjjGop5D/d/urakEp02cOE57W6Qz14BQ7/WpJdPdJ fTxemSZheRRVmaB0vtB3eQBh926q3VKKtCJZTcXc/t7f1rym61uQdo4KwzmTdjNxPmbi n6YSRgxcjvy5a1U0t/g0+DXzJHMyH9Aa0Bk1b+25B7ZGRSyVold9ojK3Ln3t3iydJfs2 fmvdio6gwnvp2vNw+Ym7TBe7sfY/uaUFsI/pGMAnc2K9BvBHDr+dipvs/3lnpcKGaHn8 YcMV99eb4ARFcNYUkk1yqjcmz9W9d6wIAz+u5pLyKqzsuLD6k9dZOtsfwxz6hD9Cg5/D oLlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="N+fgwF/6"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x25si10998399oie.261.2020.02.20.00.37.49; Thu, 20 Feb 2020 00:38:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="N+fgwF/6"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727298AbgBTIgO (ORCPT + 99 others); Thu, 20 Feb 2020 03:36:14 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36716 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbgBTIf4 (ORCPT ); Thu, 20 Feb 2020 03:35:56 -0500 Received: by mail-pl1-f195.google.com with SMTP id a6so1280932plm.3 for ; Thu, 20 Feb 2020 00:35:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wYQONlA9lvcFld0G+NwhV5rBbyIu6fNUKkg/bhapB14=; b=N+fgwF/6e6JTKFlrJgQIRnbOLpsKCtZYnIYWWcKNnfKNY9CCUMr6V9Gw9TGF6pjJIB EHSAyjOJyfeCwqQkmI4hUnJOnoferabWuW52Jemsyz3ozxX45q3P64AnHJpigGKXMWzg wBZNL9EgTQWFnkbTSNbeoeGpldgIni5ogrZfMmarImqShr+dejWNmNW96uI2OQSM/DiG TbWyOd6OuhzcE+KwC0rYa/X8GMZFSoOWT0/63ZQIGG5D9x0EvG1IvBxr9J8jYpAcdO0a 4Za6FD12Z2xqA0PCoc8lNH2bo+yCBkGwRyZmRXN6uApIHstunbaeA/WX/yObPRwoUFUG f+NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wYQONlA9lvcFld0G+NwhV5rBbyIu6fNUKkg/bhapB14=; b=jnFT6diFITU+b5gHGaIu7Dk2ppvu7UIeP3+k3evXq8Z3+iPTvqfvK6rq45a9G6u/0A 8cQwc6PSofVkmz1uuwk6nlQyTm/a3tCRzGV/53n2ekEaMoVez7IJ1itrCAVh0pY9sk8j Q9r7msR0suJNt2NKwvwbxvJlfO4ZLjv7BQ2OwK83lLoomcTghaMyQBE6as3Im09dgcCS AaRPMeUqV2RA/bnXfNCT8fM/3HBnTaymiAKx8RDZlty+yrsR6BvS1FRBXtoY7BeKQHcT EvGAol7uWO1DdBCYBxNG6Y++AXP64JwkK2f5JIaHeQs+UHVk/nrUoL9lWVnasqeRplnv D7Dw== X-Gm-Message-State: APjAAAVL3ixtTod76Pm7EmOlz1Nh23HUE7R5mb+sAshFTbVg2jKpcfDi 5Noz5/lQ7WsJlxaCqEUF1NI= X-Received: by 2002:a17:90a:c216:: with SMTP id e22mr2300961pjt.134.1582187755353; Thu, 20 Feb 2020 00:35:55 -0800 (PST) Received: from anarsoul-thinkpad.lan (216-71-213-236.dyn.novuscom.net. [216.71.213.236]) by smtp.gmail.com with ESMTPSA id l13sm2319038pjq.23.2020.02.20.00.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 00:35:54 -0800 (PST) From: Vasily Khoruzhick To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Icenowy Zheng , Torsten Duwe , Heiko Stuebner , Linus Walleij , Stephan Gerhold , Mark Brown , Stephen Rothwell , Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Vasily Khoruzhick Subject: [PATCH 2/6] drm/bridge: anx6345: Clean up error handling in probe() Date: Thu, 20 Feb 2020 00:35:04 -0800 Message-Id: <20200220083508.792071-3-anarsoul@gmail.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200220083508.792071-1-anarsoul@gmail.com> References: <20200220083508.792071-1-anarsoul@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_regulator_get() returns either a dummy regulator or -EPROBE_DEFER, we don't need to print scary message in either case. Signed-off-by: Vasily Khoruzhick --- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index 0d8d083b0207..0204bbe4f0a0 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c @@ -713,17 +713,13 @@ static int anx6345_i2c_probe(struct i2c_client *client, /* 1.2V digital core power regulator */ anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12"); - if (IS_ERR(anx6345->dvdd12)) { - DRM_ERROR("dvdd12-supply not found\n"); + if (IS_ERR(anx6345->dvdd12)) return PTR_ERR(anx6345->dvdd12); - } /* 2.5V digital core power regulator */ anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25"); - if (IS_ERR(anx6345->dvdd25)) { - DRM_ERROR("dvdd25-supply not found\n"); + if (IS_ERR(anx6345->dvdd25)) return PTR_ERR(anx6345->dvdd25); - } /* GPIO for chip reset */ anx6345->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); -- 2.25.0