Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp641376ybv; Thu, 20 Feb 2020 04:53:36 -0800 (PST) X-Google-Smtp-Source: APXvYqz8jG7fRLVbAINAGWFwjjF3EblWasNTPzAuE8xlGbh63Y5Cyd1KSWaZZeNlL4B9GtrYm7CH X-Received: by 2002:a9d:4c92:: with SMTP id m18mr22307742otf.168.1582203216058; Thu, 20 Feb 2020 04:53:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582203216; cv=none; d=google.com; s=arc-20160816; b=tNuBDmA2O9g9ZhiqNT7Bi5ZtNuZn99HNOsr0QS3gIfzwzwMvVJT2DI6pSVqcwN5rtD 75neH7JC8dV+MPvLTM6/kQAo9DVCBX8/m8eOiMr8CP4JSSzchOWfAo4z8MSWDArOntQF 0rgNtBRx+KbQJ5iJNLUK8Qapdv+l+2KdxLb4VfWRfYwsY6oZPevmjeCqUYA7EkHuo7C8 g2CJaDLMngJchSm66amysIrC5Vtc0t1cu35pynelt5tXqmus5sgF8/bbscYU4g0XwsRp PZfvbNCvGJLdCGYiy+g9BPfDn4rvjD6oXnn9H4I3KP2slIhIsmOHhFgL89yjAvsJRUZS +ncw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:in-reply-to:subject:cc:to:from :date; bh=IVgBf5no7VQmPN5Nb7chYOlQFS0Rbv8gRE7WfxjpEt0=; b=NQHm1bPnLAjVMgjAZAZET7lJ+wDDaUyYnXURSTaQYS2MARZpiHPNUtraw3Toqzwicw 9V4qDzhP8uaWFWX66EdMaM42kMhvctNgEE618vcRl5DVTvFRyoHXYdNqeufh1OvrfdPw bbHuUHtzxhh5FSmFLLX5muFIkO2XcgXCDPr9wSamn4osWMR1SRRtvTs8SdEsQytE52c/ 3OhKsM5ziTk7o5s+79tlc5Y5v1fuEayIEO4Zb+fvGw1tYUpbFQPTj6bA91ekHZa54Qqc /R0RGXTK8JikMbDn+WWGxVpo4HD6lxmLwPcu328upCvWJicJTmk+dAOH3j2bNPrgqsUn fSdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t22si1683164oth.211.2020.02.20.04.53.22; Thu, 20 Feb 2020 04:53:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728051AbgBTMwF (ORCPT + 99 others); Thu, 20 Feb 2020 07:52:05 -0500 Received: from foss.arm.com ([217.140.110.172]:42218 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727747AbgBTMwE (ORCPT ); Thu, 20 Feb 2020 07:52:04 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 038ED31B; Thu, 20 Feb 2020 04:52:04 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 79AA03F703; Thu, 20 Feb 2020 04:52:03 -0800 (PST) Date: Thu, 20 Feb 2020 12:52:01 +0000 From: Mark Brown To: Jerome Brunet Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Pierre-Louis Bossart Subject: Applied "ASoC: dpcm: remove confusing trace in dpcm_get_be()" to the asoc tree In-Reply-To: <20200219115048.934678-1-jbrunet@baylibre.com> Message-Id: X-Patchwork-Hint: ignore Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: dpcm: remove confusing trace in dpcm_get_be() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 9d6ee3656a9fbfe906be5ce6f828f1639da1ee7f Mon Sep 17 00:00:00 2001 From: Jerome Brunet Date: Wed, 19 Feb 2020 12:50:48 +0100 Subject: [PATCH] ASoC: dpcm: remove confusing trace in dpcm_get_be() Now that dpcm_get_be() is used in dpcm_end_walk_at_be(), it is not a error if this function does not find a BE for the provided widget. Remove the related dev_err() trace which is confusing since things might be working as expected. When called from dpcm_add_paths(), it is an error if dpcm_get_be() fails to find a BE for the provided widget. The necessary error trace is already done in this case. Fixes: 027a48387183 ("ASoC: soc-pcm: use dpcm_get_be() at dpcm_end_walk_at_be()") Signed-off-by: Jerome Brunet Tested-by: Pierre-Louis Bossart Acked-by: Kuninori Morimoto Cc: Kuninori Morimoto Link: https://lore.kernel.org/r/20200219115048.934678-1-jbrunet@baylibre.com Signed-off-by: Mark Brown --- sound/soc/soc-pcm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 63f67eb7c077..aff27c8599ef 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1270,9 +1270,7 @@ static struct snd_soc_pcm_runtime *dpcm_get_be(struct snd_soc_card *card, } } - /* dai link name and stream name set correctly ? */ - dev_err(card->dev, "ASoC: can't get %s BE for %s\n", - stream ? "capture" : "playback", widget->name); + /* Widget provided is not a BE */ return NULL; } -- 2.20.1