Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp696686ybv; Thu, 20 Feb 2020 05:49:12 -0800 (PST) X-Google-Smtp-Source: APXvYqyhVZoGrGzHaDHUyjd0hqoLN0hTK8ksYWRdNCFfC5CryHToGum7guYUJ5lSdT6WCEgpMkUY X-Received: by 2002:a9d:10d:: with SMTP id 13mr11481844otu.238.1582206551953; Thu, 20 Feb 2020 05:49:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582206551; cv=none; d=google.com; s=arc-20160816; b=Y5nk7qGyPZBC0XQuZrXKk2QyYoSd8/jpQ3Nfd6UB/IKmbl4vpn4UlG3sZ1dSARnOHd Ktf3PZ/oJTT8EVjtiYROuN0LSgCGsly6Rk8X5UYaAd+3m++ExUXP/yxxvMSiiFJorZmt YnbEyebZB5kU1hThHOBvoqa7/n1UMgG06qxPtVXpW8j9HN7V0MfA9wwOkHvVpuSXJ6t1 n17JnsDREUFaQfpukt0a6hneiAPWxHS+rHOcAGhmv5BStEIjSu5uyi1+coblAknqiPgZ XuA5R/W1ojARndwP/v2aO5n20hr5nz8KKrw1PauJewDXZGdj5W40dp11doAY9F92B1s5 awOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=zBQV1Nvl6gQ7063nOMO4bl4Qit9dtUsePu9xZtdIUpM=; b=tImByJJ5or9stbXAZZMtqyLyenzg8hjYdjkit92+pyfjne+iUt6LaP9ddpaNA0IGPb urVyqfGorxVbbUWKWxxLkW3mp8bqoqtFQuLx1I1k52QxVD9BoiI/SzNgsFVgjRXDVFeI o80JorsYKFXycrmC6MyENvvQovYbRta93Gp+3mcUHLlUvZc6wb5rgraHkOmPG1jssu0G DyI3g2HyZiOQGdmxNwti7FKcqP3Pb6eCW0PPYSIHuAJI4XId0TFTSXqLjy94rm+9D67U dwnnV1vS/HN1pistD/Y4V2XnH73V9rK6UAHXMtCTnT84GMmQ+q97CWm83rYmuzn2TsGC A+6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=igtOB94R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si1707311otl.214.2020.02.20.05.48.59; Thu, 20 Feb 2020 05:49:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=igtOB94R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728266AbgBTNsu (ORCPT + 99 others); Thu, 20 Feb 2020 08:48:50 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:35948 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728042AbgBTNsu (ORCPT ); Thu, 20 Feb 2020 08:48:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zBQV1Nvl6gQ7063nOMO4bl4Qit9dtUsePu9xZtdIUpM=; b=igtOB94RI8XKtzVTmpl7adfTBc nUPRfeBQAn6qgMu2mIMXdqdemGWBPZM6m1mk0JRQ4gln6YP021QrTz7JW7WriTW9kQd9HhefrWodr DPdZE7ea3rkTiKxZzjV2rfZFsVohFeCSeKjLKjW2laQNPicIuou8l8cd1nA0LgsCPlX64i0y7yahW 32HPR3UOUNpTTE89QggDpsf9Uy+G746NO+E5c6nPo49C7MXOyuBpobo2jZnaHlZEfffwdWw5lxpdO LXm98qt8lqtRm5JiZBti5MLazqN7XkI5SW89icHM4E2rVuaoGC9UJqrtuJmXRDlbntv0SnHwa7P6h mNHva41Q==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4mC9-0006TC-8A; Thu, 20 Feb 2020 13:48:49 +0000 Date: Thu, 20 Feb 2020 05:48:49 -0800 From: Matthew Wilcox To: Johannes Thumshirn Cc: "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "cluster-devel@redhat.com" , "ocfs2-devel@oss.oracle.com" , "linux-xfs@vger.kernel.org" Subject: Re: [PATCH v7 14/24] btrfs: Convert from readpages to readahead Message-ID: <20200220134849.GV24185@bombadil.infradead.org> References: <20200219210103.32400-1-willy@infradead.org> <20200219210103.32400-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 20, 2020 at 09:42:19AM +0000, Johannes Thumshirn wrote: > On 19/02/2020 22:03, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > Use the new readahead operation in btrfs. Add a > > readahead_for_each_batch() iterator to optimise the loop in the XArray. > > OK I must admit I haven't followed this series closely, but what > happened to said readahead_for_each_batch()? > > As far as I can see it's now: > > [...] > > + while ((nr = readahead_page_batch(rac, pagepool))) { Oops, forgot to update the changelog there. Yes, that's exactly what it changed to. That discussion was here: https://lore.kernel.org/linux-fsdevel/20200219144117.GP24185@bombadil.infradead.org/ ... and then Christoph pointed out the iterators weren't really adding much value at that point, so they got deleted. New changelog for this patch: btrfs: Convert from readpages to readahead Implement the new readahead method in btrfs. Add a readahead_page_batch() to optimise fetching a batch of pages at once.