Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c
To:     "Dr. David Alan Gilbert" <linux@treblig.org>,
        Meelis Roos <mroos@linux.ee>
Cc:     linux-hwmon@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Chen Zhou <chenzhou10@huawei.com>
References: <434212bb-4eb9-7366-3255-79826d0e65bc@linux.ee>
 <20200220121451.GA18071@gallifrey>
 <6050ed14-f7a6-cb99-7268-072129226d48@linux.ee>
 <20200220135709.GB18071@gallifrey>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <ad023dc1-1878-dcd9-a183-06003ed698af@roeck-us.net>
Date:   Thu, 20 Feb 2020 06:40:15 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200220135709.GB18071@gallifrey>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/20/20 5:57 AM, Dr. David Alan Gilbert wrote:
> * Meelis Roos (mroos@linux.ee) wrote:
>>> It looks like not all chips have temp_label, so I think we need to change w83627ehf_is_visible
>>> which has:
>>>
>>>                   if (attr == hwmon_temp_input || attr == hwmon_temp_label)
>>>                           return 0444;
>>>
>>> to
>>>                   if (attr == hwmon_temp_input)
>>>                           return 0444;
>>>                   if (attr == hwmon_temp_label) {
>>>                           if (data->temp_label)
>>> 				return 0444;
>>> 			else
>>> 				return 0;

Nitpick: else after return isn't necessary. Too bad I didn't notice that before;
static analyzers will have a field day :-)

>>>                   }
>>>
>>> Does that work for you?
>> Yes, it works - sensors are displayed as they should be, with nothing in dmesg.
>>
>> Thank you for so quick response!
> 
> Great, I need to turn that into a proper patch; (I might need to wait till
> Saturday for that, although if someone needs it before then please shout).
> 

We'll want this fixed in the next stable release candidate, so I wrote one up
and submitted it.

Thanks,
Guenter