Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp754722ybv;
        Thu, 20 Feb 2020 06:45:45 -0800 (PST)
X-Google-Smtp-Source: APXvYqxGZrBYCqekhvtXg3IAeNJd8YElz2hzspS5NLV9dvrt7/0VkN70gwOxny0YIa7A5aJfrvo1
X-Received: by 2002:aca:ad47:: with SMTP id w68mr2226340oie.63.1582209945110;
        Thu, 20 Feb 2020 06:45:45 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1582209945; cv=none;
        d=google.com; s=arc-20160816;
        b=iqagDGpi3odEpyWvLb8jUYIDbNYBb5nYFHDCL2cnxRNt4hi7zg2Sly8yWS64B59nsy
         KOMvSNsS61vvEJqyGrRUkrkjxOm/tfPOwE0s8x1jEABMmiXOZ2YWxMchqQFIKW+AJIl7
         Cj0zfEY3NtoAxdG+pkEG8fX/EJzq5LBNgaZyAl3Z1+QPO/1TxBebjg5ZP13zj7WgjbrF
         LAFB89/cczCcWozUolxiyp9bf3Yl6b1nBYkz+UG904OUaj2RL3HsZlWBG9GpcfgszsQi
         cgyDjErKcAeQoxgm0ZSUxYAwq3vXlGUkAWmKXrddqu2JzyCs2jwaLvHkIA2lYu7+MihB
         eJ6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=ToZh4/TyGAmvxNYeBR1CnaphoSG1rFK0lkkCxri83P0=;
        b=HUXeI4wo4iLqTt8UYWOczQmpSB3rQ3gjAai+1iCDlG4NnOwM/YstcoqJ1hlGSxC8TH
         Xd14WT9fVM+wX65PRwELOmaaTbzjJdsjxhhUbaBbsRkRETkmasL/ON7JK9bD4UI4uXG/
         9bqWB8FdwzZVKBy+RUZSxd+KnJg178a7nKo7+ZQRGt4aCxU27SkCSEswcVExd9gaO3oH
         vYHXASS4yaLMCkSvvMtZdzvikQJXDU75IKpSd0GhQthold+oJ4Sw87xf47Jegq1/5v4y
         IInRznV5n2Y52F2HJEYXaV0OujhaEqGXZMb7bjkYwMrrZubtnO9cvbnkxXJ35dOaf1u0
         SwPA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=OdHnmCRo;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id x186si10208758oig.209.2020.02.20.06.45.32;
        Thu, 20 Feb 2020 06:45:45 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=OdHnmCRo;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728090AbgBTOpO (ORCPT <rfc822;justmaker@gmail.com> + 99 others);
        Thu, 20 Feb 2020 09:45:14 -0500
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:13963 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727298AbgBTOpO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Feb 2020 09:45:14 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e4e9b6b0002>; Thu, 20 Feb 2020 06:44:59 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 20 Feb 2020 06:45:13 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 20 Feb 2020 06:45:13 -0800
Received: from [10.21.133.51] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 20 Feb
 2020 14:45:10 +0000
Subject: Re: [PATCH v3 04/10] ASoC: tegra: add Tegra210 based I2S driver
To:     Sameer Pujar <spujar@nvidia.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <robh+dt@kernel.org>
CC:     <broonie@kernel.org>, <lgirdwood@gmail.com>,
        <thierry.reding@gmail.com>, <digetx@gmail.com>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sharadg@nvidia.com>, <mkumard@nvidia.com>,
        <viswanathl@nvidia.com>, <rlokhande@nvidia.com>,
        <dramesh@nvidia.com>, <atalambedu@nvidia.com>
References: <1582180492-25297-1-git-send-email-spujar@nvidia.com>
 <1582180492-25297-5-git-send-email-spujar@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <8b224e0f-5e69-75a4-6be1-fb7bc083bf32@nvidia.com>
Date:   Thu, 20 Feb 2020 14:45:07 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <1582180492-25297-5-git-send-email-spujar@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1582209899; bh=ToZh4/TyGAmvxNYeBR1CnaphoSG1rFK0lkkCxri83P0=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=OdHnmCRoqtioB67vc9TZUhgUh9GReTNHyKRyE5tjc/IXkXP37oPK2DERs1ItzJlcC
         Tp8NbO0WDwEvxskGu++2Qnvc7WCT/emskqisVdxNQkQlG5oiIXutOovinGt7JNq+XE
         geoXtQVATTsQyiUSib0iSJFK7CPOMcQ458c9iZvr5xo/du8pw8e9u6x0Fhp9AnDhKd
         av4WhzWL/HZ4xjBl9+FPbzabsZXAQB4GCtQoejfAny6JXo7B+16K663y33XmmHreFs
         Fj1wkT6ZF+UBm514kW5N+CJDzcu8MpIGetazvw6UgiDQeUoX9B1K7XUtaQEKGyiqC1
         bFbFq7de4WjYg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 20/02/2020 06:34, Sameer Pujar wrote:
> The Inter-IC Sound (I2S) controller implements full-duplex, bi-directional
> and single direction point to point serial interface. It can interface
> with I2S compatible devices. Tegra I2S controller can operate as both
> master and slave.
> 
> This patch registers I2S controller with ASoC framework. The component
> driver exposes DAPM widgets, routes and kcontrols for the device. The DAI
> driver exposes I2S interfaces, which can be used to connect different
> components in the ASoC layer. Makefile and Kconfig support is added to
> allow to build the driver. The I2S devices can be enabled in the DT via
> "nvidia,tegra210-i2s" compatible binding.
> 
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
>  sound/soc/tegra/Kconfig        |  10 +
>  sound/soc/tegra/Makefile       |   2 +
>  sound/soc/tegra/tegra210_i2s.c | 938 +++++++++++++++++++++++++++++++++++++++++
>  sound/soc/tegra/tegra210_i2s.h | 132 ++++++
>  4 files changed, 1082 insertions(+)
>  create mode 100644 sound/soc/tegra/tegra210_i2s.c
>  create mode 100644 sound/soc/tegra/tegra210_i2s.h

Thanks!

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic