Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp779219ybv; Thu, 20 Feb 2020 07:10:15 -0800 (PST) X-Google-Smtp-Source: APXvYqwnGeHNaC0BjwuckXnIpmHnxvDi0U2smb6Lm4gWKxDNoTPzofoB7/Ea1cnmB1nC1ijp2R/F X-Received: by 2002:a05:6808:315:: with SMTP id i21mr2304679oie.139.1582211415273; Thu, 20 Feb 2020 07:10:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582211415; cv=none; d=google.com; s=arc-20160816; b=ZOfdkDJj4Pah2heMAUFxrKWiIgu9rMi4bR3GNn3iicGmfKhjBaQYcStHcC/h+nfe1X utWgd/TmtDarimweMZyEb/DQyhPcJ8J6IeJL5ulBz6E8eQQlR4qwERmLJmrxSH5H5485 Ze0NKw8M4141dciqXDeEba4KX1l41NXn8huw29FWWi/gVLG0YqlVmsYBSjDvXd2NDG8Y +fiBhSg8VED6Ocasg25cgjtAtbL1DmrUif3M9/njiT6SP9e16dXHvYhKy8p+7M48vaXK iMthReJbi1/ABU2qJdfuY+4KXdoVVtpSdciJuiAj/q2tsYh0ntCpjSrdNMpr2VtOgXyc Lo6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=obd51ZNsw5FfUS2fhNr47ZW+jghzqsavfkWVv8Zb46k=; b=rDRjo70F4zlA4sWyGEqrHYpgK4sxTfT5xQctTpM6IVUrjKJSG7MrYwMRZqGWZioeND JUP0FEmAmelTXwbdm2cppuwIPFkGAt8/3qjRl9nR0iL457vZPe8BkgCSJIcfnMSDp5cd Df0QCPQzmfRI+ofEkf9qBX0RwrGSB+/OuMn4QgYaAvJ91c5M/ZPWUUlQGvwShu3DRq68 Vh9eweabUEu//lnoHp3PgaTnB6p034QXCrjMlMPeLBmPaMUG+TJMCot70hrJjfw5ZsbQ PfnBfd+gEHv/4tQhh60YfzQDSfGDNdaPQm25t2XnV5UO8Z76wS/+/bSXwvc1ipMsKSPR 0Kug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e126si11638541oib.21.2020.02.20.07.09.50; Thu, 20 Feb 2020 07:10:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728460AbgBTPJG (ORCPT + 99 others); Thu, 20 Feb 2020 10:09:06 -0500 Received: from muru.com ([72.249.23.125]:56274 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728176AbgBTPJG (ORCPT ); Thu, 20 Feb 2020 10:09:06 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id DE1ED8080; Thu, 20 Feb 2020 15:09:48 +0000 (UTC) Date: Thu, 20 Feb 2020 07:09:01 -0800 From: Tony Lindgren To: Lee Jones Cc: Pavel Machek , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz, agx@sigxcpu.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, jjhiblot@ti.com Subject: Re: [PATCH] backlight: add led-backlight driver Message-ID: <20200220150901.GG37466@atomide.com> References: <20200219191412.GA15905@amd> <20200219194540.GD37466@atomide.com> <20200220074849.GF3494@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220074849.GF3494@dell> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lee Jones [200220 07:49]: > On Wed, 19 Feb 2020, Tony Lindgren wrote: > > > * Pavel Machek [200219 19:15]: > > > From: Tomi Valkeinen > > > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > > > Signed-off-by: Tomi Valkeinen > > > Signed-off-by: Jean-Jacques Hiblot > > > Acked-by: Pavel Machek > > > Reviewed-by: Daniel Thompson > > > Acked-by: Lee Jones > > > Acked-by: Tony Lindgren > > > Tested-by: Tony Lindgren > > > Signed-off-by: Pavel Machek > > > --- > > > drivers/video/backlight/Kconfig | 7 ++ > > > drivers/video/backlight/Makefile | 1 + > > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 268 insertions(+) > > > create mode 100644 drivers/video/backlight/led_bl.c > > > > > > Hi! > > > > > > Here's the version of the driver I have. AFAICT > > > default-brightness-level handling is ok, so does not need to be > > > changed. > > > > > > Lee, it would be easiest for me if you could apply it to your tree and > > > push, but given enough time I can push it to Linus, too. > > > > Oh you're using quoted-printable for patches.. Got it applied now, > > and it still works. Below is also the related dts change that > > I tested with. > > > > Feel free to pick the dts change too, naturally that should > > not be applied before the driver. > > > > If you guys instead want me to pick these both into my fixes > > branch, just let me know and I'll do the explaining why these > > are needed as fixes. Basically we no longer have a way to enable > > the LCD backlight for droid4 manually starting with v5.6-rc1 > > unlike earlier. > > Please do. You already have my Ack. OK pushed out these two patches in omap-for-v5.6/droid4-lcd-fix. Thanks, Tony