Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Feb 2020 15:52:04 +0000
From:   "Dr. David Alan Gilbert" <linux@treblig.org>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Meelis Roos <mroos@linux.ee>, linux-hwmon@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Chen Zhou <chenzhou10@huawei.com>
Subject: Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c
Message-ID: <20200220155204.GC18071@gallifrey>
References: <434212bb-4eb9-7366-3255-79826d0e65bc@linux.ee>
 <20200220121451.GA18071@gallifrey>
 <6050ed14-f7a6-cb99-7268-072129226d48@linux.ee>
 <20200220135709.GB18071@gallifrey>
 <ad023dc1-1878-dcd9-a183-06003ed698af@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ad023dc1-1878-dcd9-a183-06003ed698af@roeck-us.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Guenter Roeck (linux@roeck-us.net) wrote:
> On 2/20/20 5:57 AM, Dr. David Alan Gilbert wrote:
> > * Meelis Roos (mroos@linux.ee) wrote:
> > > > It looks like not all chips have temp_label, so I think we need to change w83627ehf_is_visible
> > > > which has:
> > > > 
> > > >                   if (attr == hwmon_temp_input || attr == hwmon_temp_label)
> > > >                           return 0444;
> > > > 
> > > > to
> > > >                   if (attr == hwmon_temp_input)
> > > >                           return 0444;
> > > >                   if (attr == hwmon_temp_label) {
> > > >                           if (data->temp_label)
> > > > 				return 0444;
> > > > 			else
> > > > 				return 0;
> 
> Nitpick: else after return isn't necessary. Too bad I didn't notice that before;
> static analyzers will have a field day :-)
> 
> > > >                   }
> > > > 
> > > > Does that work for you?
> > > Yes, it works - sensors are displayed as they should be, with nothing in dmesg.
> > > 
> > > Thank you for so quick response!
> > 
> > Great, I need to turn that into a proper patch; (I might need to wait till
> > Saturday for that, although if someone needs it before then please shout).
> > 
> 
> We'll want this fixed in the next stable release candidate, so I wrote one up
> and submitted it.

Thanks!

Dave

> Thanks,
> Guenter
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/