Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp823860ybv; Thu, 20 Feb 2020 07:57:49 -0800 (PST) X-Google-Smtp-Source: APXvYqweN67uj1lxeOT51Ht31tmthEw6LsAWNVtOxermsYjENSFlTKjpqhkL4r92okiuNzANeOz3 X-Received: by 2002:a9d:7602:: with SMTP id k2mr24386952otl.39.1582214269560; Thu, 20 Feb 2020 07:57:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582214269; cv=none; d=google.com; s=arc-20160816; b=aaVDtMNnBOD9S4tz17Lg956kmbqaZj7qwlw1ZIPJG6JXxRZSnfdk6TfZRm3PP5PWnU HKtUewUgK0TUIJ2o2A2gQa9e2O/VUcmQwMqm7C3xuyuIABMby2rp3N+G+XNr2xEmKNEE Y0KLD/gsDr977oQuJ5LGeyU9GmAYy4o87hl1hSPamyg3BdP34yFg75aiGYTRkz+unbQu jBLS3Dbbw5UCkAAckfEDK5X3srKvK4Uk/SnOF2nXE/14Xt34x6O5C7CafT58h+PTCAsp K60TP3H9tVMSXT22FxkJqXoj7Gb/VV8RGa3CZEAWO2eNsb7+zivizQ9Aa2c/q11U8kfE GkFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+/UHJ6F1pbYDweJDUZAgvqKfayrQBowwGTnz0WdYGiI=; b=Y+bmZXTkvHbxHZX3OiLFKHG3pIgpEeuZQhXF/Q6KmR0aPXrJxIBv1gAwnlgoknAIaS xsl1U7uERzC9oQ7IoMGLDU7P9/R6Ydg+IokvSncz1cPRuqax+69vcemVFPWuI2eYkagh b3sgoXDQi5ez17VwWyG9H3sUbhXMCitmgJ9547yUUxxbP2zcc5zJ9uA9eIW4Xo4WnoHF 3NSxu7MIQG7nxWBqtc0Uwyr0p2pMYFZNvLILOPlCAXSusDIZZ9f9Xg5ebvwkyq1/Zq1F JbvaKnRFzQ2DzrqCZyd+mhDod/00RW67n9MHELvGhyj3wELXMZHTHO6I24y8gvm+4iZf TvjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=otE+N0vt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si1896811otq.96.2020.02.20.07.57.38; Thu, 20 Feb 2020 07:57:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=otE+N0vt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728659AbgBTP52 (ORCPT + 99 others); Thu, 20 Feb 2020 10:57:28 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:57658 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728410AbgBTP52 (ORCPT ); Thu, 20 Feb 2020 10:57:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+/UHJ6F1pbYDweJDUZAgvqKfayrQBowwGTnz0WdYGiI=; b=otE+N0vtlyX9xN010Sejc78VWm +Z6Nhr8BvmGUNrIO9afuJHhxoLPaunjuFqSB3Vbfkg92cFJ3CGndTAJiSloW8688jbu+LsyPnwsfM 7+EZh4a1KpVzbLiwzv7LZrgnYjvExYmxe48vBmhmvCOPmZ7sVJnLeHwyQwYksv3nnnaQLNldoXsYQ u1gQv6uFtIOengP5ajM30qweiLUQ49UDY3r+ygUvyonu17lsTwaYIiH/5oz7IhvQ4fhsYNWJY/9Ww eOATcZg8cPjWf2FcknrxS05+tCQGLf31jvSwLk8Ndl9n4CBxBjuYStE6NyuIbPzCKDkbX2IXV3hgI bWJ8ZdIw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4oCd-0000Ht-HF; Thu, 20 Feb 2020 15:57:27 +0000 Date: Thu, 20 Feb 2020 07:57:27 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Johannes Thumshirn , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "cluster-devel@redhat.com" , "ocfs2-devel@oss.oracle.com" , "linux-xfs@vger.kernel.org" Subject: Re: [PATCH v7 14/24] btrfs: Convert from readpages to readahead Message-ID: <20200220155727.GA32232@infradead.org> References: <20200219210103.32400-1-willy@infradead.org> <20200219210103.32400-15-willy@infradead.org> <20200220134849.GV24185@bombadil.infradead.org> <20200220154658.GA19577@infradead.org> <20200220155452.GX24185@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220155452.GX24185@bombadil.infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 20, 2020 at 07:54:52AM -0800, Matthew Wilcox wrote: > On Thu, Feb 20, 2020 at 07:46:58AM -0800, Christoph Hellwig wrote: > > On Thu, Feb 20, 2020 at 05:48:49AM -0800, Matthew Wilcox wrote: > > > btrfs: Convert from readpages to readahead > > > > > > Implement the new readahead method in btrfs. Add a readahead_page_batch() > > > to optimise fetching a batch of pages at once. > > > > Shouldn't this readahead_page_batch heper go into a separate patch so > > that it clearly stands out? > > I'll move it into 'Put readahead pages in cache earlier' for v8 (the > same patch where we add readahead_page()) One argument for keeping it in a patch of its own is that btrfs appears to be the only user, and Goldwyn has a WIP conversion of btrfs to iomap, so it might go away pretty soon and we could just revert the commit. But this starts to get into really minor details, so I'll shut up now :)