Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp840358ybv; Thu, 20 Feb 2020 08:12:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyL+OrZW/4lNZT3oBB0SI9moZ3W+Hb+FLe472Gowh9BhCDfT976JvYM6V0bOP854YTChTvp X-Received: by 2002:a9d:7590:: with SMTP id s16mr22848659otk.89.1582215165525; Thu, 20 Feb 2020 08:12:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582215165; cv=none; d=google.com; s=arc-20160816; b=TiDWPQrP88fRUtnHjJV8Chqjeg2aj2oyYin3ieAKn74u7+MIi7jiCRvcMoUWsatv2c NjJPVKYsAJjwxBpOzdooqF3afd2VaTtMvTCbIb7BjjsvBn/JbEq5ubUbBFLBUpKd8F9B qfz0iNG/UbBrRQ2bn0T3VTV8c7MqcjvrZGnAJPjD8tNX9OSSo1M2ZI3nmzgRC+sQ9Rnd RMMzJbq3r615s04qM7ZSYZbeLeCTuIWiCGRm/q06U8BGRbJxXW0XIUrEJBIpkYBGVk33 Dheme/7qSYwPw0TZj76xrvEaxoDgzKEudR8jd+He8qFLGHQnLdrV2jlC/Cic2caCzDGn B42A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Q2WMrKJPsS5sPIrkud+pa9+1gC7XpmqI0W5s90VJfAE=; b=A2uMoKMDaqFudjsTeNfhM43txfFZl2YbdomAD6RsnFYnMmmlse6KnC+ZR0kwwIdpTc q7pbbqM7+6SYSaCxPMMPObBPfUTw5rJjrlouTnlN46IRTSyuCAs7rhtkQTFyG06UH8xw bXMEmbv5yxHFfIV3h9uDHmO29sjIJYOajXa4d2cYMDZbRqYLMVPXaSJdwMzr8+ki+z12 ecLG7fgaCylHY6iSiWRcuU5esIFZRzhiZwVCIA/Uy9/+rWfhe0rMqPgqXvA9Z7EpFIOL xg0wGlM/s9s9rFzGoMpygCsFJyHyjxaAsI+QpdGxr7ckkDnQugIPZ9qiXJyIyVBqOJ9F yc3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l22si3645389oie.32.2020.02.20.08.12.29; Thu, 20 Feb 2020 08:12:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728650AbgBTQLw (ORCPT + 99 others); Thu, 20 Feb 2020 11:11:52 -0500 Received: from verein.lst.de ([213.95.11.211]:50174 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728493AbgBTQLv (ORCPT ); Thu, 20 Feb 2020 11:11:51 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id F1DC068C4E; Thu, 20 Feb 2020 17:11:46 +0100 (CET) Date: Thu, 20 Feb 2020 17:11:46 +0100 From: Christoph Hellwig To: Halil Pasic Cc: "Michael S. Tsirkin" , Jason Wang , Marek Szyprowski , Robin Murphy , Christoph Hellwig , linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Christian Borntraeger , Janosch Frank , Viktor Mihajlovski , Cornelia Huck , Ram Pai , Thiago Jung Bauermann , David Gibson , "Lendacky, Thomas" , Michael Mueller Subject: Re: [PATCH 1/2] mm: move force_dma_unencrypted() to mem_encrypt.h Message-ID: <20200220161146.GA12709@lst.de> References: <20200220160606.53156-1-pasic@linux.ibm.com> <20200220160606.53156-2-pasic@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220160606.53156-2-pasic@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 20, 2020 at 05:06:05PM +0100, Halil Pasic wrote: > Currently force_dma_unencrypted() is only used by the direct > implementation of the DMA API, and thus resides in dma-direct.h. But > there is nothing dma-direct specific about it: if one was -- for > whatever reason -- to implement custom DMA ops that have to in the > encrypted/protected scenarios dma-direct currently deals with, one would > need exactly this kind of information. I really don't think it has business being anywhre else, and your completely bogus second patch just proves the point.