Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp959228ybv; Thu, 20 Feb 2020 10:20:46 -0800 (PST) X-Google-Smtp-Source: APXvYqwcvs6PBKIHl8UFtCvgTeA9rpXYcRb2bwc8zV/sTR8MHZPMUu4nBMQNUrooItBSDNpDF+/p X-Received: by 2002:aca:503:: with SMTP id 3mr2986752oif.24.1582222845872; Thu, 20 Feb 2020 10:20:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582222845; cv=none; d=google.com; s=arc-20160816; b=m5IYkoB6FOEe6h3Aufbhkx3Ipj2LwQ5XIWdG2ulFM3XSIz1Mtq59iWNhgvBkf4oAyZ RbNbtoJf0pDPG9pLYB7doPLzPxFDQCCBcKTVhcqyCI4bNm5ldrI5uKxztExgBEpAe45u cuY8AutQYmnd2HeJ+btU6i+h2rGXR5hwMTVMvz0EAJjzC3O8YtrMbV4yPzWtK8yNNsSk q1VE8Whtr3GO930bby4CxK2gdxwoT1ZSUddRhJxwT81jLmYJLqC/0Nop70QZoEor8amv jkOibZ5GtYOuQWtHbxs0T7IA5HSpNncEDd3cRhU8jVjNknP4aYyz1aZ6N37gCls1C+Rh 63KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=BMudXWRavzU8ncImx/aSRyw9UQtZ0RxHFgnxmYTgr/o=; b=sgJUlDdgTI3GZ5suZKss4uuiU3u5CizRdkeHtRY06rITPx4/np7zwdiNzP4eQowv9/ 09v6hsrgjwFnsxFh4Az0F8d9+ftUxDsJBCHEaOE7T1lfAHEIGSS2QDtXy28m6bICLHam SY6Kuf9z20oXDsJaOfO7IsQCBtkgkb8HikoUescAi4YbJN+m7SH9LTpTT2zkszeLE24a bC3VIyJLPOnSCJyVMDXF9vtJsLZtoNrzJWDwmDEK/CxePcjv4ihoM/n4HY6y923WRNEd gLeEc6BCLb4hxO6SFs3U2B3Yb2y9OgC/0jgwzFelQpK5UCicEGtIuVyronwxBosxlagR QZ4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lebedev-lt.20150623.gappssmtp.com header.s=20150623 header.b=Xj26QZhS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c144si16011oig.263.2020.02.20.10.20.32; Thu, 20 Feb 2020 10:20:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lebedev-lt.20150623.gappssmtp.com header.s=20150623 header.b=Xj26QZhS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728237AbgBTSTG (ORCPT + 99 others); Thu, 20 Feb 2020 13:19:06 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40823 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbgBTSTG (ORCPT ); Thu, 20 Feb 2020 13:19:06 -0500 Received: by mail-lf1-f66.google.com with SMTP id c23so3862060lfi.7 for ; Thu, 20 Feb 2020 10:19:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lebedev-lt.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BMudXWRavzU8ncImx/aSRyw9UQtZ0RxHFgnxmYTgr/o=; b=Xj26QZhSq3ROB90ZKv65EPbntTSjJUf3ya+rYi7+K0z+zCwE2HDMhX6XR2ngsFAHrk WqseTzGt6xHvQJvJmqulNHCpJczepO4PqkrxTfihTZO2iq5t0TofG1ZTnI4uoRA7ufvL qskk6GiWl9zsd3upI1+AWYLf1LoNDh+dEFxaEfWRQuYAl7dYFxZN46AOnn2OtFxwXt+g 5CbB0cbMdLH72cWILlpauiaDrf7+0Zk+frFtn8HCuzccfS1fxF5bKeLitpE7V23PVtEF BWNTIpUXt8oEvVgKoMo1Ycii4G0XS7B9lo4Wl/9WHMu9xDvuroOt5XWmNBsN7kEsIwsy 763A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BMudXWRavzU8ncImx/aSRyw9UQtZ0RxHFgnxmYTgr/o=; b=DSPsyGEstqIlyWHed7BByh2+Tx0RE3lvGAF3MIW/x2uKTqUVbrVhIviQc93QhvGOQq qFkc4QaQyqgtLMdO6pGIPOYSvhT1WgU5F9rW29pD01mEhvM1GunXsRlTa8FrcLHYnxw1 YP412uPDRHHSP1t20vvpZbjU2JTonDEvbVYKYxUhQgkZl0qFZXSUDokKDgEp8dLXR1Gm aE+6V0jLHDe/JwCW6Tnug0/H2YbGdpMX7Uz0rz9eu4lOUzH8YT99VAQu+VRz2d/qYHk0 uKC+v6u8d1NclcStNlwpkKnSDXlhLilVWwDsI9PKKsBlQGVcrdBkumuNiNramOnM1Hq0 PB8g== X-Gm-Message-State: APjAAAU0zgQsbiV/8fXEfD6imoEbFioTaXJji7EesH36PpvM5etVn7Tf kZOSG6Ba9T5LKKFSZtd5ZP8S4g== X-Received: by 2002:a19:97:: with SMTP id 145mr16976846lfa.98.1582222743500; Thu, 20 Feb 2020 10:19:03 -0800 (PST) Received: from [192.168.1.108] ([5.20.204.163]) by smtp.gmail.com with ESMTPSA id m21sm156300lfb.59.2020.02.20.10.19.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2020 10:19:02 -0800 (PST) Subject: Re: [PATCH 1/5] drm/sun4i: tcon: Introduce LVDS setup routine setting To: Maxime Ripard , Andrey Lebedev Cc: wens@csie.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com References: <20200210195633.GA21832@kedthinkpad> <20200219180858.4806-1-andrey.lebedev@gmail.com> <20200219180858.4806-2-andrey.lebedev@gmail.com> <20200220172154.22gw55s2mzyr45tj@gilmour.lan> From: Andrey Lebedev Message-ID: <1002d964-28c9-ed69-64fe-6527418092bb@lebedev.lt> Date: Thu, 20 Feb 2020 20:19:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200220172154.22gw55s2mzyr45tj@gilmour.lan> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/20/20 7:21 PM, Maxime Ripard wrote: >> + regmap_write_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG, >> + SUN6I_TCON0_LVDS_ANA0_EN_DRVD(0xf), >> + SUN6I_TCON0_LVDS_ANA0_EN_DRVD(val)); >> + >> +} >> + > There's an extra blank line here that was reported by checkpatch. I've > fixed it up while applying. Weird, checkpatch didn't warn me about that: ./scripts/checkpatch.pl patches/0001-drm-sun4i-tcon-Introduce-LVDS-setup-routine-setting.patch total: 0 errors, 0 warnings, 103 lines checked patches/0001-drm-sun4i-tcon-Introduce-LVDS-setup-routine-setting.patch has no obvious style problems and is ready for submission. In any case, thanks for correcting it! -- Andrey Lebedev aka -.- . -.. -.. . .-. Software engineer Homepage: http://lebedev.lt/