Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1076436ybv; Thu, 20 Feb 2020 12:42:57 -0800 (PST) X-Google-Smtp-Source: APXvYqx24BaYTT7VKZoljq94ht8SNUmBd+qH+GA/qF6Nlk4m0+rffqYxregE9yko7ERZVckZE9PS X-Received: by 2002:a05:6830:1c8:: with SMTP id r8mr12543751ota.63.1582231377089; Thu, 20 Feb 2020 12:42:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582231377; cv=none; d=google.com; s=arc-20160816; b=w3NT00QpusReGsIwBVmoRdYh8oqEybMr0/8YQbOV29r+s+rrvG+gfrYmckSUmJHQy2 5VTe4ARFKS+MHX3cIG4hHU4/sYJ/T7a8fOEkY1QVruqE3O2jZPayCqPZBbJJa7ZzVFXC j8NYDLEfdZNB8KtLj5U7UxvIPk6f3L1zLrdsaK24q14Jmlum9pJEVTV/2+ioVMdDwCdg x6Om1DAJ8+anpts1lojxSPJW/CFDBysGir7oIqHsdiX6OFbiIMFHY6aAb5cKn7D0qOM/ xjpmvJApkAYgbqZYhFxIVNnyiSossOH7YmJwlNJ7HoovKPrpip7ZYO+dBJnFUnOnsv+I eWXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=9IhKZI8WwIvJaT/r6ACexW9pb3kFD91r1SniUFRsEL4=; b=DDZoaMv3OkAIcLX4Aageg4WTkIiD9+5YwqlywJceCsG2kpxD07LUVaTdGuesNOG3Ob ogewmY4RPJvyJe7aChXXGG3c5i1eQCNWFFIaRGdZg51LqfXb3lMIM0zkcu8d/1yl+v2L 2Pzedz1z18qXSNwoyBiYCuVll3LWFjPd01h5fxXsZ277mKcaY6OTzIcYYQt/wBwfx5+8 CFviZL6tgUN0H/CEwTWP7BX4evVOlYNsWIISiDZVjdGGD2yqfbJaevefFTPRLWbTFS4Y GtJfefzLKbJeT77HMUM8mBNNgXVeqZQwtKXzuadJT2jIXWCoL46heoSzbSJ+pahw/4xY acbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x23si282499otq.41.2020.02.20.12.42.43; Thu, 20 Feb 2020 12:42:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728969AbgBTUme (ORCPT + 99 others); Thu, 20 Feb 2020 15:42:34 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:48557 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728618AbgBTUme (ORCPT ); Thu, 20 Feb 2020 15:42:34 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4se0-000106-Uk; Thu, 20 Feb 2020 21:42:00 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j4sds-0001Ks-T6; Thu, 20 Feb 2020 21:41:52 +0100 Date: Thu, 20 Feb 2020 21:41:52 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Yangtao Li , thierry.reding@gmail.com Cc: claudiu.beznea@microchip.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com, nsaenzjulienne@suse.de, shc_work@mail.ru, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, matthias.bgg@gmail.com, heiko@sntech.de, palmer@dabbelt.com, paul.walmsley@sifive.com, mripard@kernel.org, wens@csie.org, jonathanh@nvidia.com, linux@prisktech.co.nz, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 30/32] pwm: hibvt: do some cleanup Message-ID: <20200220204152.p6rublsssifvvnvk@pengutronix.de> References: <20191229080610.7597-1-tiny.windzz@gmail.com> <20191229080610.7597-30-tiny.windzz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191229080610.7597-30-tiny.windzz@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 29, 2019 at 08:06:08AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > 'i' and 'ret' are variables of the same type and there is no > need to use two lines. I think I wouldn't have merged these two lines, but I don't feel strong here. The other 31 patches are clean replacements. But I also don't think respining just for this minor thing is worth the effort, so: Acked-by: Uwe Kleine-K?nig for the whole series. (Not sure it is sensible to ack each patch individually, @Thierry, tell me if this simplifies things for you.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | https://www.pengutronix.de/ |