Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1138314ybv; Thu, 20 Feb 2020 14:03:23 -0800 (PST) X-Google-Smtp-Source: APXvYqxE6Fyw81y6H0HlrXSrki7AD/TjF9o4EyhintwE9ArP/jcyMEBbvwerNb3JnFJFTNNdtcLm X-Received: by 2002:a05:6830:22e2:: with SMTP id t2mr25891037otc.129.1582236203356; Thu, 20 Feb 2020 14:03:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582236203; cv=none; d=google.com; s=arc-20160816; b=EMfD64EGfOmQ+4UrhD/NB3Y77L7bRmN+d/N1cUSQwCzOZUHqtP39eio2tbuZkvXnrb kt2Tq3CF4MdR5mMI33mo1CDRjEGDmFhSJuojXuRdvG/wZsjiKLuItVgk4sMnm/Si1R/z 5iTm+ILuNe/cb3ZAEKGNKfUiCvZlw6TxVVw5dxOQgH1M2l0wh1pJw1X+ERH1eA5tVBAx SQSfMXQD/FZyL2P/ClAURTERJf0+GSOe9Bap752Xp/uImiO+ITuSIwQNaHMTaKCQuw39 LiEN5m4xGRx3jYdkjLHmO2JE6iSrC6l1+JHcK/lYvLPlcof7iTZoKezV6FnvpnmihMmf +FMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Qs+LhNiBMIj9A7PLEkqadpwwdn4t7ZJVTcZjDGn03PM=; b=z+rMHivLhao//Q5fkow3QSME2odccDv8+hzlbxNbfB9VRViQW3pT2CMuQPv9Ph84Fz VBLgHnMMlKs212DCLnNk1S/DjVaEVIW46goNgyV5TXqe7Nfv2sDuxDYB/qMNfAjJot5i mpvIF15CI0Nh+Zfw/pTIlVJ+v5i+iit45cuqAe2rMCdPKNDjtMnkBjR/RIq9L2g1wL3h cirmSTc2fJvnak5OpCRt6gPZ/Htt3EK9T4PqOsr2icVgdcKJtXHJ2GQxxEwRdm45R8hh RGgUwyhYYCSpe22Xk/PmnJNn4CTFdzxZLWVztRx/H9/z9mlyqGz/jQiHnAs0ceZH+ycK lMuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=1sM+flAa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19si295906oij.107.2020.02.20.14.03.10; Thu, 20 Feb 2020 14:03:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=1sM+flAa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728993AbgBTWCl (ORCPT + 99 others); Thu, 20 Feb 2020 17:02:41 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:42755 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727656AbgBTWCl (ORCPT ); Thu, 20 Feb 2020 17:02:41 -0500 Received: by mail-qk1-f193.google.com with SMTP id o28so24038qkj.9 for ; Thu, 20 Feb 2020 14:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qs+LhNiBMIj9A7PLEkqadpwwdn4t7ZJVTcZjDGn03PM=; b=1sM+flAalAjdf9H+ABF4RBpnc7mgf/EB1PkQ3GIvPhatEPuYG/+kZZYytUx2breYo9 oBS4Cz3/NHUDHKrF1wClmlsU2wMQWRh9jUeUVFlKDnYU1XDy2DbPjMAN6/dFKk+WparC n2mnFSbEJsFPwZS1Vkfj9gnphTLnT9mqRYcdYb3mcnuK5c108UQ0b24WLrAoGSNFpyha iPLMyEc4PN5W+kfi2o4BOepzuEVVQ0MwF8HwWATiYKm8p4b2uSETdNaNTVOHwu7ULX5K 9cl6gc557oQYGhjYLQyYi1BtFt0PWyzSVcxVJSRFwVQAzbgf64CESMf7EXkdNMTvkNc/ T1Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qs+LhNiBMIj9A7PLEkqadpwwdn4t7ZJVTcZjDGn03PM=; b=ULxBLP9CBFbF2sIPUgaEiAVtFUfK43VzLUy8BmdtjNyw29MgKcQstZwZYr42dfRZbr ek0NStSWKHH7qKE5FPX3H2xL0yRXwazjK8fmqakUvVUS+cuvoLUo6jxwwBMn2mw2e7V8 ejYUT/+jgXbd25rtn+Q7yISFi+tpVENIuclfxYnka3zEPtSdeunQkAnujJGS4wST3gzB P7mJRqeG3obafYF4xR7LU5BdQUxYF4hfLjJWjJw70q4JLbDAtziEPfXmx9Bhd7vX4p6n 17RpM9s8wz96qpMvMKrgyMJ6r/9AF1QPyfOLfrJQ7v9CcVHUY+muursuVHg7uaU/N9C0 +aAg== X-Gm-Message-State: APjAAAVaNnQy1nmGqea8ZdzhjAgsderc9NVFeotBErhJx0NJXEDFk5Im 6RrkN/G5Hmv+OMp2IXa9aQZYiw== X-Received: by 2002:a05:620a:1037:: with SMTP id a23mr29030822qkk.82.1582236160287; Thu, 20 Feb 2020 14:02:40 -0800 (PST) Received: from localhost ([2620:10d:c091:500::1:3504]) by smtp.gmail.com with ESMTPSA id e16sm518875qkl.32.2020.02.20.14.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 14:02:39 -0800 (PST) Date: Thu, 20 Feb 2020 17:02:38 -0500 From: Johannes Weiner To: Dan Schatzberg Cc: Jens Axboe , Tejun Heo , Li Zefan , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Roman Gushchin , Shakeel Butt , Chris Down , Yang Shi , Thomas Gleixner , "open list:BLOCK LAYER" , open list , "open list:CONTROL GROUP (CGROUP)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Subject: Re: [PATCH v3 3/3] loop: Charge i/o to mem and blk cg Message-ID: <20200220220238.GB68937@cmpxchg.org> References: <78060dcbf6578b4da6081f9f48b24b33726c5083.1582216295.git.schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78060dcbf6578b4da6081f9f48b24b33726c5083.1582216295.git.schatzberg.dan@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 20, 2020 at 11:51:53AM -0500, Dan Schatzberg wrote: > The current code only associates with the existing blkcg when aio is > used to access the backing file. This patch covers all types of i/o to > the backing file and also associates the memcg so if the backing file is > on tmpfs, memory is charged appropriately. > > This patch also exports cgroup_get_e_css so it can be used by the loop > module. > > Signed-off-by: Dan Schatzberg The cgroup bits look good to me. Acked-by: Johannes Weiner