Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200216161836.1976-1-Jason@zx2c4.com> <20200216182319.GA54139@kroah.com>
In-Reply-To: <20200216182319.GA54139@kroah.com>
From:   Tony Luck <tony.luck@gmail.com>
Date:   Thu, 20 Feb 2020 14:20:26 -0800
Message-ID: <CA+8MBbKScktNPWPgMqexp9gSX+y2FVnXTDJyyEMVsdONPBpFrQ@mail.gmail.com>
Subject: Re: [PATCH] random: always use batched entropy for get_random_u{32,64}
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "Jason A. Donenfeld" <Jason@zx2c4.com>, "Ted Ts'o" <tytso@mit.edu>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Feb 16, 2020 at 10:24 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:

> >  drivers/char/random.c | 12 ------------
> >  1 file changed, 12 deletions(-)
>
> Looks good to me, thank for doing this:
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Perhaps also needs to update the comment above these functions.

Specifically the bit that says "The quality of the random
number is either as good as RDRAND" ... since you are
no longer pulling from RDRAND it isn't true anymore.

-Tony