Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Feb 2020 16:16:01 -0800
From:   Kees Cook <keescook@chromium.org>
To:     shuah <shuah@kernel.org>
Cc:     Cristian Marussi <cristian.marussi@arm.com>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        lkft-triage@lists.linaro.org,
        open list <linux-kernel@vger.kernel.org>, ankita@in.ibm.com,
        Will Deacon <will@kernel.org>, ardb@kernel.org,
        "Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>
Subject: Re: selftests: Linux Kernel Dump Test Module output
Message-ID: <202002201610.2B149A6D@keescook>
References: <CA+G9fYu3682XJ2Kw2ZvQdUT80epKc9DWWXgDT1-D_65ajSXNTw@mail.gmail.com>
 <fcb799d4-f316-60d6-9fd0-0bc1c174e63c@arm.com>
 <31b066c2-d1c9-1592-48cd-bccb4b3a624a@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <31b066c2-d1c9-1592-48cd-bccb4b3a624a@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 19, 2020 at 09:16:03AM -0700, shuah wrote:
> On 2/17/20 8:36 AM, Cristian Marussi wrote:
> > Hi
> > 
> > n 17/02/2020 11:09, Naresh Kamboju wrote:
> > > The selftest lkdtm test failed on x86_64 and arm64.
> > > am I missing any pre-requisite?
> > > 
> > > Boot log:
> > > [    3.297812] lkdtm: No crash points registered, enable through debugfs
> > > 
> > 
> > from your logs I cannot deduce anything useful, but in our CI I've got similar issues
> > since the 10/12th of Feb...
> > 
> > TAP version 13
> > 1..71
> > # selftests: lkdtm: PANIC.sh
> > # Cannot find /sys/kernel/debug/provoke-crash/DIRECT (missing CONFIG_LKDTM?)
> > not ok 1 selftests: lkdtm: PANIC.sh # SKIP
> > # selftests: lkdtm: BUG.sh
> > # Cannot find /sys/kernel/debug/provoke-crash/DIRECT (missing CONFIG_LKDTM?)
> > 
> > so I suppose this and a bunch of other (probably new) tests are simply
> > missing a bit of CONFIGs... (but I have still to look into this properly)
> > (not sure if this also is your case either...)
> > 
> > Regards
> > 
> > Cristian
> > 
> 
> Hi Kees,
> 
> Any ideas on what this is about? Missing config or something else?

In the first case, I'm not sure what's happening -- the logs don't seem
to show anything, but the lkdtm should be available (from the boot log).

In the second case, yes, it looks like missing CONFIG_LKDTM (the test
even has a "config" file). Either CONFIG_LKDTM=y or CONFIG_LKDTM=m will
work (the test running will attempt to load the lkdtm module if it's
missing).

A final option is that either the debug filesystem isn't mounted, or is
mounted somewhere "non-standard"? (I'd expect a lot of things to fail...)

-Kees

-- 
Kees Cook