Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1264950ybv; Thu, 20 Feb 2020 16:42:08 -0800 (PST) X-Google-Smtp-Source: APXvYqyKXAeyS6QiaJ7OfrRiLNTHF+IY+g18IDWyu0TDCYFkFp0a5uru9lxRuxbx2Qg4v5imgnQ+ X-Received: by 2002:a9d:3f4b:: with SMTP id m69mr24064852otc.146.1582245728249; Thu, 20 Feb 2020 16:42:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582245728; cv=none; d=google.com; s=arc-20160816; b=Uk50ldNlnuHQH7y1ykcKLQeFpURlMD9c0zz2qtQbpvmIBcdkWWkZibBupqJrcEosTE Z9ft1UWEUTbmuulVNIwJw0khnAoEQluo3lY0qZXIKEn/UxpGq+V1I8cVNsdbXwMD2Tdp wUhdKjvRVAh5OYCIBNNSOjMnz10iJmX5ZBO5wyjt0nIyNiNiNFmFh6zsQ0KwJd60Vku7 TVQcMTyBLhKZO7AEkH5pur4c+u9zhyNZ/VV6FgjoXsEWfV+FsfLWW2MXA9/HvqSPpTKA FSLSjvsnRgutTfBFrmOJwPMRmci2XbPa+pDsaARmR5hqpaiaWTcVArXOndxxRVvFWLxZ h2lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4ogVh1CaJio0SSCbWW6O2ox37tZbWvACvh4kN38fTBk=; b=QwFx3OXJ7mKnEk6HCM7wygOLMBWMja/zTZ1M0Qz5t/CYTyjITet14W9q7pIJLNkM2x LtGJa9B43gYrFmQxE85rhyvXfGRm7/GSBTzs4SIXtH4ZSfgitqgZlwZBcFVWl0m6MBFn 0DQmOWRZQdA4LtlJoy130xpS91aaBjXUyAC1G7+7ZmMNfGy1wMjJU35OpCNYwad4n1cR tTe/gU3cPcqGNP0t9Ku7EUyYgXG5A2I0JSTKGvUsq0ovgA6LpFNTqp5eqQcKVrUssrKN 2eQOcZfz0NKIEHvgsrL9zFjqanszAF4DDI0dgb2GVoOMPSil5/11SWREyDJvBgUGd9UO DlpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q65si531771oic.123.2020.02.20.16.41.56; Thu, 20 Feb 2020 16:42:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729456AbgBUAlp (ORCPT + 99 others); Thu, 20 Feb 2020 19:41:45 -0500 Received: from mga02.intel.com ([134.134.136.20]:20199 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729582AbgBUAll (ORCPT ); Thu, 20 Feb 2020 19:41:41 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 16:41:41 -0800 X-IronPort-AV: E=Sophos;i="5.70,466,1574150400"; d="scan'208";a="315906277" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.157]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 16:41:40 -0800 From: ira.weiny@intel.com To: linux-kernel@vger.kernel.org Cc: Ira Weiny , Jan Kara , Alexander Viro , "Darrick J. Wong" , Dan Williams , Dave Chinner , Christoph Hellwig , "Theodore Y. Ts'o" , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH V4 03/13] fs: Remove unneeded IS_DAX() check Date: Thu, 20 Feb 2020 16:41:24 -0800 Message-Id: <20200221004134.30599-4-ira.weiny@intel.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200221004134.30599-1-ira.weiny@intel.com> References: <20200221004134.30599-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ira Weiny Remove the check because DAX now has it's own read/write methods and file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on their own. Therefore, it does not matter if the file state is DAX when the iocb flags are created. Reviewed-by: Jan Kara Signed-off-by: Ira Weiny --- Changes from v3: Reword commit message. Reordered to be a 'pre-cleanup' patch --- include/linux/fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 3cd4fe6b845e..63d1e533a07d 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3388,7 +3388,7 @@ extern int file_update_time(struct file *file); static inline bool io_is_direct(struct file *filp) { - return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host); + return (filp->f_flags & O_DIRECT); } static inline bool vma_is_dax(struct vm_area_struct *vma) -- 2.21.0