Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1334740ybv; Thu, 20 Feb 2020 18:09:28 -0800 (PST) X-Google-Smtp-Source: APXvYqzqyKsWE2Jg2K0tWbUNc2jE7TNFm9y9cFcERDIaQvfmw8/MrYidF1LLkgSzYx/uoJY/NSEc X-Received: by 2002:a05:6830:1e6b:: with SMTP id m11mr27041257otr.293.1582250968734; Thu, 20 Feb 2020 18:09:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582250968; cv=none; d=google.com; s=arc-20160816; b=XR+xS6tyaHBU7cHl4vW1Jcy7WVkMCFIs/aqN2G0hXAN8SSpzn+YlJn0U5j+qwBElbY uolGFwFITW7S1TygaUOYfZMRhGLOoVLGuNW4C1uobwL10GUCEXR0wUeF7xGzItVAB45c 9Q4rZ3lJR6WlAx8gjyGsY+YsEWLdpDjmcbOxmqglw8TKBSHEqK6OpxcMO6gYR/OvSGPS QsDQKMUU0Skoee1HrHpn0wswSE77J4XY0jbRN1r+9u8lsVH3mOtmcaUBmgA4XuclFAnD Ro9Ev3TvU2K5qctx75k6Pa5fF9W8YUHrWfb8WUM29FWPf2BiTpla4mYi+6KS3vvwrRcF A1WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6tj1hAhO4MSdUKmdTH78t/V6caDIoDIEzSKzOb9pc2U=; b=JEZj2LcOaq6aC15oABPIUsf4WJriBFl5kUFtdCmosDf/JAh7/Gdz1of3kOYgUg6xid c0BgKGlPINJ0p+pVudLmXcLGuu8pwD6eUj7DFx3hzwEteFU2E8ns0uVBI3t7ItGZK98c K4w1dIpBKA62sSDKxMls1GofYYoG41+oBogeVOVW0Ot3k2yhVxebEEqZJ0QqruNLUcSz s4jXSVfBMsC2OtLCVk1lulPeSDjw5VORQOkhoyf0cnqNBC9OZEUpWVQdQTIbBplnJ0yu fQEh+yrIHWV6VsG6rsl38j38AjXXL7EPu/5HS2sGX1e0xPUuOFYiXQ9xRyD4IUlMYAXa G5jA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si824350otj.24.2020.02.20.18.09.16; Thu, 20 Feb 2020 18:09:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729415AbgBUCIA (ORCPT + 99 others); Thu, 20 Feb 2020 21:08:00 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:60196 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727845AbgBUCIA (ORCPT ); Thu, 20 Feb 2020 21:08:00 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id C9E913A4B175E03AC2E3; Fri, 21 Feb 2020 10:07:58 +0800 (CST) Received: from DESKTOP-8RFUVS3.china.huawei.com (10.173.222.27) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Fri, 21 Feb 2020 10:07:50 +0800 From: Zenghui Yu To: CC: , , , Zenghui Yu Subject: [PATCH] genirq/irqdomain: Make sure all irq domain flags are distinct Date: Fri, 21 Feb 2020 10:07:25 +0800 Message-ID: <20200221020725.2038-1-yuzenghui@huawei.com> X-Mailer: git-send-email 2.23.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This was noticed when printing debugfs for MSIs on my ARM64 server. The new dstate IRQD_MSI_NOMASK_QUIRK came out surprisingly while it should only be the x86 stuff for the time being... It's the overlap in irqdomain flags which leads to this confusion. (1 << 1) might be a good choice for old IRQ_DOMAIN_NAME_ALLOCATED, use it to avoid this overlap. Fixes: 6f1a4891a592 ("x86/apic/msi: Plug non-maskable MSI affinity race") Signed-off-by: Zenghui Yu --- include/linux/irqdomain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index b2d47571ab67..8d062e86d954 100644 --- a/include/linux/irqdomain.h +++ b/include/linux/irqdomain.h @@ -192,7 +192,7 @@ enum { IRQ_DOMAIN_FLAG_HIERARCHY = (1 << 0), /* Irq domain name was allocated in __irq_domain_add() */ - IRQ_DOMAIN_NAME_ALLOCATED = (1 << 6), + IRQ_DOMAIN_NAME_ALLOCATED = (1 << 1), /* Irq domain is an IPI domain with virq per cpu */ IRQ_DOMAIN_FLAG_IPI_PER_CPU = (1 << 2), -- 2.19.1