Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932126AbWBJOW6 (ORCPT ); Fri, 10 Feb 2006 09:22:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932111AbWBJOW2 (ORCPT ); Fri, 10 Feb 2006 09:22:28 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:56721 "EHLO fgwmail7.fujitsu.co.jp") by vger.kernel.org with ESMTP id S932115AbWBJOWN (ORCPT ); Fri, 10 Feb 2006 09:22:13 -0500 Date: Fri, 10 Feb 2006 23:21:46 +0900 From: Yasunori Goto To: Andi Kleen , "Luck, Tony" , "Tolentino, Matthew E" Subject: [RFC/PATCH: 010/010] Memory hotplug for new nodes with pgdat allocation.(allow -EEXIST of add_memory) Cc: linux-ia64@vger.kernel.org, Linux Kernel ML , x86-64 Discuss , Linux Hotplug Memory Support X-Mailer-Plugin: BkASPil for Becky!2 Ver.2.063 Message-Id: <20060210224740.C548.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.24.02 [ja] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 48 When acpi_memory_device_init() is called at boottime to register struct memory acpi_memory_device. So, acpi_bus_add() are called via acpi_driver_attach(). But it also calls ops->start() function. It is called even if the memory blocks are initialized at early boottime. In this case add_memory() return -EEXIST, and the memory blocks becomes INVALID state even if it is normal. This is patch for it. Signed-off-by: Yasunori Goto Index: pgdat2/drivers/acpi/acpi_memhotplug.c =================================================================== --- pgdat2.orig/drivers/acpi/acpi_memhotplug.c 2006-02-10 15:35:34.000000000 +0900 +++ pgdat2/drivers/acpi/acpi_memhotplug.c 2006-02-10 15:35:36.000000000 +0900 @@ -201,8 +201,18 @@ static int acpi_memory_enable_device(str * Note: Assume that this function returns zero on success */ result = add_memory(mem_device->start_addr, mem_device->length); - if (result) { - ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "\nadd_memory failed\n")); + switch(result) { + case 0: + break; + case -EEXIST: + ACPI_DEBUG_PRINT((ACPI_DB_INFO, + "\nmemory start=%lu size=%lu has already existed\n", + mem_device->start_addr, + mem_device->length)); + return 0; + default: + ACPI_DEBUG_PRINT((ACPI_DB_ERROR, + "\nadd_memory failed result=%d\n", result)); mem_device->state = MEMORY_INVALID_STATE; return result; } -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/