Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 19B54C43383
Subject: Re: [PATCH 1/2] dt-bindings: Introduce soc sleep stats bindings for
 Qualcomm SoCs
To:     Stephen Boyd <swboyd@chromium.org>, andy.gross@linaro.org,
        david.brown@linaro.org, linux-arm-msm@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        bjorn.andersson@linaro.org, evgreen@chromium.org,
        dianders@chromium.org, rnayak@codeaurora.org, ilina@codeaurora.org,
        lsrao@codeaurora.org, devicetree@vger.kernel.org,
        Mahesh Sivasubramanian <msivasub@codeaurora.org>
References: <20190808061228.16573-1-mkshah@codeaurora.org>
 <20190808061228.16573-2-mkshah@codeaurora.org>
 <5d4c4bb6.1c69fb81.db640.7518@mx.google.com>
From:   Maulik Shah <mkshah@codeaurora.org>
Message-ID: <9b106bc1-572a-a277-c88b-d6960b3cec35@codeaurora.org>
Date:   Fri, 21 Feb 2020 11:27:38 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <5d4c4bb6.1c69fb81.db640.7518@mx.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 8/8/2019 9:50 PM, Stephen Boyd wrote:
> Quoting Maulik Shah (2019-08-07 23:12:27)
>> Add device binding documentation for Qualcomm Technology Inc's (QTI)
>> SoC sleep stats driver. The driver is used for displaying SoC sleep
>> statistic maintained by Always On Processor or Resource Power Manager.
>>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> Your SoB chain is odd. The author is Mahesh? Otherwise, use the
> Co-Developed-by tag.
corrected in v2.
>> ---
>>   .../bindings/soc/qcom/soc-sleep-stats.txt     | 36 +++++++++++++++++++
>>   1 file changed, 36 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.txt
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.txt b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.txt
>> new file mode 100644
>> index 000000000000..ee40687ded34
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.txt
>> @@ -0,0 +1,36 @@
>> +* SoC Sleep Stats
>> +
>> +Always On Processor/Resource Power Manager maintains statistics of the SoC
>> +sleep modes involving lowering or powering down of the backbone rails - Cx
> What is a 'backbone' rail?
done.
>
>> +and Mx and the oscillator clock, XO.
> Drop the comma? XO is the oscillator clock.
done.
>
>> +
>> +Statistics includes SoC sleep mode type, number of times low power mode were
>> +entered, time of last entry, time of last exit and accumulated sleep duration.
>> +SoC Sleep Stats driver provides sysfs interface to display this information.
> Can this document be YAML? Then it can be validated.
converted to YAML in v2.
>
>> +
>> +PROPERTIES
>> +
>> +- compatible:
>> +       Usage: required
>> +       Value type: <string>
>> +       Definition: Should be "qcom,rpmh-sleep-stats" or "qcom,rpm-sleep-stats".
>> +
>> +- reg:
>> +       Usage: required
>> +       Value type: <prop-encoded-array>
>> +       Definition: The base address on the Always On Processor or Resource Power
>> +                   Manager from where the stats are read.
>> +
>> +EXAMPLE 1:
>> +
>> +       rpmh_sleep_stats: soc-sleep-stats@c3f0000 {
>> +               compatible = "qcom,rpmh-sleep-stats";
>> +               reg = <0 0xc3f0000 0 0x400>;
> Is this memory region in DDR? Or some specific IMEM location? I wonder
> if it would be better to just have a pointer from the RPM node to this
> memory region and then populate some stats if so.
Not a DDR.
>
>> +       };
>> +

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation