Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1587177ybv; Thu, 20 Feb 2020 23:48:34 -0800 (PST) X-Google-Smtp-Source: APXvYqzwgEOFWpOLwoj+GjTCwwrE6JIpodGkYiBWCxUSR3d8MYBu2RrTPj/2bF3JVIDo6QbtjVAW X-Received: by 2002:a05:6808:b29:: with SMTP id t9mr926818oij.69.1582271314761; Thu, 20 Feb 2020 23:48:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582271314; cv=none; d=google.com; s=arc-20160816; b=mdSXfbv/gM7WSwAraViRoI9zL/pgPgbDap2nllrS23vQ7A6KNtA5LhdIP3IGKFlmoJ c4iAnPz2PGEIexud2Ge9dDaCDRRaB6IJm4Uonykf+QG4wQoY5xMNu2YpfRxvS8rR9fcA dkqwFqXdZccj7IGnGnc5Wb0LVT5CiZ/hIC7oe1j6QQN88vDemPi/quTbnddHfMa78g9n m9Pvwx52CyQySZ03JmczQvtlr2PqVB5vi3oCLxaLL5A9E2EecBLr9dkvG01cKneBAtYE MVhmVhgjIHExXNt+ehaf/gcCSxpOxuV55i3F9DTVYKqS5G2dZH89RqAHZ1DQJOo5qW2s 0rTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hBX4qKva9m4sjRiHr04bGBGUh3QO093vYd4wNQwyfsU=; b=k4CiMc/T76np5B+r4PBwRkGC9IiYqEDBNg5Fd0a6UwnRaZeiY06KxUr6HQs0PTURmQ O/EZ7MKK/enWZ7ChYpiTQS7nTGhk/bF7ZDHO4ntmXSeQXhfhm2k4CZAoITbUNl11CZ5x NDPZh54P7etgbNFxSjMi7rRzfYvXATo8z/O/RuQ60KiGXPNhlmQpJ2Pkj0FtLGz54rnz qJTVwg4UjCqwAos4tES2BVKqztFFcAOobqBRoiKyL6BcvPt9BiLHa8a6u6BpL67mqyTg LaPZz6UapydzYkGMIEWC5CoiHkwU/8RsuGOXgQNPrFukDcDGcX22rj307Xu1CSI6HPSl N0Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GItGi85d; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1si1081955otp.91.2020.02.20.23.48.22; Thu, 20 Feb 2020 23:48:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GItGi85d; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728672AbgBUHsC (ORCPT + 99 others); Fri, 21 Feb 2020 02:48:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:44020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728686AbgBUHsB (ORCPT ); Fri, 21 Feb 2020 02:48:01 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 705D7208C4; Fri, 21 Feb 2020 07:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271280; bh=lHp6HLooUJjBCjnT0guE5tBIfkpyYzCfVXdCw7n+3+U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GItGi85dBMhYblguvs6oEdW9GjhptlGdgNgy1xraZkcpEBI+H1YtEzQ39JMBVdddn XAJa4YAfI71MuvodUo1bgmW45WOC9heRXGSth1u7CusNFItfm1f6FKxG41Eh39iGjF X6mMb+V3hA1vf9HGg99p7VcD3oDEIABoJ6AkYPUI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, yu kuai , Alex Deucher , Sasha Levin Subject: [PATCH 5.5 105/399] drm/amdgpu: remove 4 set but not used variable in amdgpu_atombios_get_connector_info_from_object_table Date: Fri, 21 Feb 2020 08:37:10 +0100 Message-Id: <20200221072412.629163673@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: yu kuai [ Upstream commit bae028e3e521e8cb8caf2cc16a455ce4c55f2332 ] Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c: In function 'amdgpu_atombios_get_connector_info_from_object_table': drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:376:26: warning: variable 'grph_obj_num' set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:376:13: warning: variable 'grph_obj_id' set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:341:37: warning: variable 'con_obj_type' set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:341:24: warning: variable 'con_obj_num' set but not used [-Wunused-but-set-variable] They are never used, so can be removed. Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") Signed-off-by: yu kuai Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c index 72232fccf61a7..be6d0cfe41aec 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c @@ -338,17 +338,9 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device * path_size += le16_to_cpu(path->usSize); if (device_support & le16_to_cpu(path->usDeviceTag)) { - uint8_t con_obj_id, con_obj_num, con_obj_type; - - con_obj_id = + uint8_t con_obj_id = (le16_to_cpu(path->usConnObjectId) & OBJECT_ID_MASK) >> OBJECT_ID_SHIFT; - con_obj_num = - (le16_to_cpu(path->usConnObjectId) & ENUM_ID_MASK) - >> ENUM_ID_SHIFT; - con_obj_type = - (le16_to_cpu(path->usConnObjectId) & - OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT; /* Skip TV/CV support */ if ((le16_to_cpu(path->usDeviceTag) == @@ -373,14 +365,7 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device * router.ddc_valid = false; router.cd_valid = false; for (j = 0; j < ((le16_to_cpu(path->usSize) - 8) / 2); j++) { - uint8_t grph_obj_id, grph_obj_num, grph_obj_type; - - grph_obj_id = - (le16_to_cpu(path->usGraphicObjIds[j]) & - OBJECT_ID_MASK) >> OBJECT_ID_SHIFT; - grph_obj_num = - (le16_to_cpu(path->usGraphicObjIds[j]) & - ENUM_ID_MASK) >> ENUM_ID_SHIFT; + uint8_t grph_obj_type= grph_obj_type = (le16_to_cpu(path->usGraphicObjIds[j]) & OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT; -- 2.20.1