Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1590206ybv; Thu, 20 Feb 2020 23:52:15 -0800 (PST) X-Google-Smtp-Source: APXvYqxkmTxLzI6p+AYI9xgkDx0rKRAnURMe+Xk9J45G4szzYoMFcGdEltch0l4nQP6CblCRjdj9 X-Received: by 2002:a9d:6b06:: with SMTP id g6mr26956662otp.93.1582271535122; Thu, 20 Feb 2020 23:52:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582271535; cv=none; d=google.com; s=arc-20160816; b=hNzuZWVQqKtOUW3eHfWYMk5FhhvbKka+P9UC8xDmNQ7hEL0OX1VNHqjMC2UilaQHju PWKmAjckv5+XyzAlO6tNich1bIglZVJv3LCQH1A5P/QWGdJUS2UiB+frxD+/yV2RcbiS 2lCUOUQRd776a+2rmpsa/kV0IdKIkcbTtyHHOqFiTOyxyps7ETJVz9qni4tKYWFdTPAu F+dxxK1DO2y6gT/++lcLoUtBGR3KdoB9+R6HFEUF8V1zrvo4Z/cBxHSLLbWbNDPYS5i4 tTZ0nCWQZEiIzh5EqLAQ4E1ew7uYkhQdjP4YHXxIUFnKQaAyECrpWyl3VCFBuAFNHenk S3HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jbfz8J5KJief9ZBNzEirZFs1fZiC2263LBwxqSgauMg=; b=cKj3WxlyRzGHzpCimAr1oAX5pvqOK9iXVNKhwwTRY6hNIboQ0kdhVEJSmDf59cIsym flA0LUQjh0QGd9nNUqJ/BymdxbZyyqAeo2ORB0b65J3Hp8FiQUphGE9bu2+Ca38FZSGP skIDAOK7tBgxjWUm2jA39jw972pDDT8FdamhHxwCdlm6PIrJm/TjKuscLkZNCIib2I09 WCdieg76CDqG30P0c/RtpJzo90Szo1TJNtM4bASko7JfS2xagrcFaq8UVkoW1YWJ2xwR yamerjSNTl1mGxD2yejRiHETwlA7DoLJJ7Hz4QD+RGI7lnlWIApURWLfVMDMlHgLIAnX 8puw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sE81feYr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h138si490301oib.6.2020.02.20.23.52.03; Thu, 20 Feb 2020 23:52:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sE81feYr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729847AbgBUHwA (ORCPT + 99 others); Fri, 21 Feb 2020 02:52:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:49562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729841AbgBUHv5 (ORCPT ); Fri, 21 Feb 2020 02:51:57 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8677324653; Fri, 21 Feb 2020 07:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271517; bh=zERLyX57mTufDyJ7gVj+1+koC2enHgrS/6UrUIXrfNo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sE81feYrsaxT2IzD1GkdEwttcmO7aN9FSUZCHTQo++mulM6ftMSmEjMW861l4yvej 0SMoBD3sGbPF09lXGu0bJBP7iQWjs4ZYO9V7LNlZU16OEyZz7kK+1QhINRAOPxFrc3 egOvcuTuoF+NnPGj80jttwtww2VaCWWJHbuUw/vY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sung Lee , Yongqiang Sun , Rodrigo Siqueira , Alex Deucher , Sasha Levin Subject: [PATCH 5.5 159/399] drm/amd/display: Fix update_bw_bounding_box Calcs Date: Fri, 21 Feb 2020 08:38:04 +0100 Message-Id: <20200221072418.007909534@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sung Lee [ Upstream commit 615b9b585eb57c1d49382d16a62de768f2c6a340 ] [Why] Previously update_bw_bounding_box for RN was commented out due to incorrect values causing BSOD on Hybrid Graphics. However, commenting out this function also may cause issues such as underflow in certain cases such as 2x4K displays. [How] Fix dram_speed_mts calculations. Update from proper index of clock_limits[] Signed-off-by: Sung Lee Reviewed-by: Yongqiang Sun Acked-by: Rodrigo Siqueira Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c index fe0ed4c09ad0a..83cda43a1b6b3 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c @@ -1352,12 +1352,6 @@ struct display_stream_compressor *dcn21_dsc_create( static void update_bw_bounding_box(struct dc *dc, struct clk_bw_params *bw_params) { - /* - TODO: Fix this function to calcualte correct values. - There are known issues with this function currently - that will need to be investigated. Use hardcoded known good values for now. - - struct dcn21_resource_pool *pool = TO_DCN21_RES_POOL(dc->res_pool); struct clk_limit_table *clk_table = &bw_params->clk_table; int i; @@ -1372,11 +1366,10 @@ static void update_bw_bounding_box(struct dc *dc, struct clk_bw_params *bw_param dcn2_1_soc.clock_limits[i].dcfclk_mhz = clk_table->entries[i].dcfclk_mhz; dcn2_1_soc.clock_limits[i].fabricclk_mhz = clk_table->entries[i].fclk_mhz; dcn2_1_soc.clock_limits[i].socclk_mhz = clk_table->entries[i].socclk_mhz; - dcn2_1_soc.clock_limits[i].dram_speed_mts = clk_table->entries[i].memclk_mhz * 16 / 1000; + dcn2_1_soc.clock_limits[i].dram_speed_mts = clk_table->entries[i].memclk_mhz * 2; } - dcn2_1_soc.clock_limits[i] = dcn2_1_soc.clock_limits[i - i]; + dcn2_1_soc.clock_limits[i] = dcn2_1_soc.clock_limits[i - 1]; dcn2_1_soc.num_states = i; - */ } /* Temporary Place holder until we can get them from fuse */ -- 2.20.1