Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1594043ybv; Thu, 20 Feb 2020 23:57:13 -0800 (PST) X-Google-Smtp-Source: APXvYqyvn2llNlnkPx/7QdK0LQ/5GqHdwj2hlGbBlN5wtFEk3dFZrop+eGpB2LphHK536SPjHdzL X-Received: by 2002:a54:4106:: with SMTP id l6mr940669oic.76.1582271833282; Thu, 20 Feb 2020 23:57:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582271833; cv=none; d=google.com; s=arc-20160816; b=TBy1N4exPcXpYvVsthS3TvW+Q7+Wdd6YokXsdpDCnhg8GVsn8VrxnHgFgNQ5bcWU10 LvyKm1QJAxJjBXMG9WoCK8LmTUnHyCmKyey9tLm290QdAP/TldExqRwzYTmfM9/2h/Ln 9sRcPbJbET/sjYhajNrKwKMGtciibsXpET+C4n4R79zCtZ64UXHrGJ4RvVw6JPPcxfyx xnrvNpGWbYFIruxEZEilDsXu/+O2zIxyNyYoMJbdLyr67+RFZn/+frZbTSYS2qcT9H6o UvaBfQJzVBZyuP+XiGuwYgUDsdu06wNIf8162rGE4ZTUkzAuEn6JIwxFBQOuYprYXhTn a7wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=iQunigwNk8aRNjFtDQqnvLFq41tnPO3vW0byn0/HiJk=; b=Cdh9/+r8V0oO7MC1dQqm1CR7KVEup/6XJLsC+M+jGdbR5qF2mPaSCWQp8u4sqAN769 9H3+YVeUcpxvm3Y5XuRZtGEnLpV1FORXL8VM6O3k7Bl+BLCfSJyq1+MNPX9JYkkXaNw4 ug/tSIvH6sPlJt/g+3ppVRpszB/o6kCK4QZWjmzGlutTR8yNf083yM0u7yUatfGuHfuf RC2n7CBoyAkdr7+hkS3PZMo9TGobOMWtTSjg7C8lYb3As7o6o/PdxABAq9igHz7pfLOt AZiM+9brqQH1M7YSZOZgsxShaGl1WaqVcMwn9QhxD6qekikX+GC7ndq8dXJ+Ic2dGJBa Ww2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bsWkmGaE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4si465993oix.48.2020.02.20.23.57.01; Thu, 20 Feb 2020 23:57:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bsWkmGaE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730546AbgBUH4z (ORCPT + 99 others); Fri, 21 Feb 2020 02:56:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:56296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730370AbgBUH4w (ORCPT ); Fri, 21 Feb 2020 02:56:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6F7920578; Fri, 21 Feb 2020 07:56:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271811; bh=y2KdCYZvWSq0h8YAq2s31CMB/GuJJswO/YD0CnIzWXQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bsWkmGaEt+MEpMarvMfD78CoD/qH2HLoI6okP9/WfiQa5+6d6ADK01z4+UZ+mmOP2 B15eXXxEz+bBjagcEbCxQlQQ+p0KfYCVm/oPOE/WZCZ1/tqROSHpz1fIJcb8YYfq/l rCuHdExpI7hoYX5Tbxf58Fe6o40jCeQ+6MvIjI/A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, yu kuai , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Thierry Reding , Sasha Levin Subject: [PATCH 5.5 306/399] pwm: Remove set but not set variable pwm Date: Fri, 21 Feb 2020 08:40:31 +0100 Message-Id: <20200221072431.363511352@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: yu kuai [ Upstream commit 9871abffc81048e20f02e15d6aa4558a44ad53ea ] Fixes gcc '-Wunused-but-set-variable' warning: drivers/pwm/pwm-pca9685.c: In function ‘pca9685_pwm_gpio_free’: drivers/pwm/pwm-pca9685.c:162:21: warning: variable ‘pwm’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. In that case, hold and release the lock 'pca->lock' can be removed since nothing will be done between them. Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()") Signed-off-by: yu kuai Acked-by: Uwe Kleine-König Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/pwm/pwm-pca9685.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 168684b02ebce..b07bdca3d510d 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b/drivers/pwm/pwm-pca9685.c @@ -159,13 +159,9 @@ static void pca9685_pwm_gpio_set(struct gpio_chip *gpio, unsigned int offset, static void pca9685_pwm_gpio_free(struct gpio_chip *gpio, unsigned int offset) { struct pca9685 *pca = gpiochip_get_data(gpio); - struct pwm_device *pwm; pca9685_pwm_gpio_set(gpio, offset, 0); pm_runtime_put(pca->chip.dev); - mutex_lock(&pca->lock); - pwm = &pca->chip.pwms[offset]; - mutex_unlock(&pca->lock); } static int pca9685_pwm_gpio_get_direction(struct gpio_chip *chip, -- 2.20.1