Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1595580ybv; Thu, 20 Feb 2020 23:59:11 -0800 (PST) X-Google-Smtp-Source: APXvYqz+qPBKMnjWfTaLC6asGLcAh0x87bZVlRdvlACqJdRO5EcjFd7or3sF8XOAUpCFmTEBEmGK X-Received: by 2002:a9d:5d09:: with SMTP id b9mr26606406oti.207.1582271951481; Thu, 20 Feb 2020 23:59:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582271951; cv=none; d=google.com; s=arc-20160816; b=M3TCi3IO0FTI+C2EmjTzNsaer+I7pL9ueTGYLpEX5E6RVr+9KJZabsdKvcuwyozbap mB7FN0/oNJNA4UFLkmE32b2SsotKWJui2Mg2lFU5BEA60Z0cEQ0wsbA3cBnwOdIhj9w5 W4hK3HeHXV5egQNtiR/K0DBxerifVyLXaqd3HB9IPkytftJ0pmAYwQvmGdxLWSxYpqRU u84qyLtN+judUFzZXgm9uI/yWPxredyKUi61Q1gOQzc0VC5j30BttjFUF/I1Yb4Fv0vd wdfkNLXmuCHleaIWAI7LrPa6tcctmoqbkOba5TslWJinfBmw1r7urK7xnEOivtesnMIL arIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ig/KRNyURNelnopIxSvn7Dx3DqlToWgwfSJ7ordnVps=; b=OpVl5+8wC6uMQTuJXnoCIlMjcRCbAwyyxVi+x7kJLJM+s70nPq5q9gqnXvrgSH/qqC nzOQZsCYhRwACm3DDqMzt+mCNrt0GsV139jPY3tBBaSxVEknzSNJFrcoV5MEl18WacNM lgwH66klkP3YFfG7UQobo+7kZS0qnZ7p7zCFJtezOh2l5TQukFFI3+0vwUj4l38vvEXL leQQScW7RU6dNEG6/IquBuJpZaCwL3Jent1TPCKNnjfVrhsq+Vb1aIQl30fYdChvSI2m zYkll/hSO/1weUAYRv3frWYcYtnHZ5VEmyRN+NUFMzEFesskKon03CiOxbJL6IuJoDdq H2RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="qnsuWW7/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13si1010848otc.228.2020.02.20.23.58.59; Thu, 20 Feb 2020 23:59:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="qnsuWW7/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730705AbgBUH55 (ORCPT + 99 others); Fri, 21 Feb 2020 02:57:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:57604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730460AbgBUH54 (ORCPT ); Fri, 21 Feb 2020 02:57:56 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2589820578; Fri, 21 Feb 2020 07:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271875; bh=r9VGlkabVTr9GSTTMrDDChb7M40vvOC140rzj7v6A9M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qnsuWW7/I7+jg5mf36qzkLDGkfNslrWKAGXVHtFkSW/CLDLkkXzAKvxcjGaxFXkim q67uPCdVBwShjveFh7Oeo1KyfrFsyf/GIeCb4Bh/gE8749AltkmPuwR3y+IOxRHP7K mVh5a65dcTOqSCX5USwydjTnZWIbrLf8cftBh6SI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang Chen , Christoph Hellwig , Coly Li , Jens Axboe , Sasha Levin Subject: [PATCH 5.5 332/399] bcache: cached_dev_free needs to put the sb page Date: Fri, 21 Feb 2020 08:40:57 +0100 Message-Id: <20200221072433.373213024@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang Chen [ Upstream commit e8547d42095e58bee658f00fef8e33d2a185c927 ] Same as cache device, the buffer page needs to be put while freeing cached_dev. Otherwise a page would be leaked every time a cached_dev is stopped. Signed-off-by: Liang Chen Signed-off-by: Christoph Hellwig Signed-off-by: Coly Li Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/bcache/super.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 77e9869345e70..a573ce1d85aae 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1275,6 +1275,9 @@ static void cached_dev_free(struct closure *cl) mutex_unlock(&bch_register_lock); + if (dc->sb_bio.bi_inline_vecs[0].bv_page) + put_page(bio_first_page_all(&dc->sb_bio)); + if (!IS_ERR_OR_NULL(dc->bdev)) blkdev_put(dc->bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); -- 2.20.1