Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1597220ybv; Fri, 21 Feb 2020 00:00:59 -0800 (PST) X-Google-Smtp-Source: APXvYqysj9vaJA9mncpMYfFsP+tihLJfewHJ3/1uF5MXzYG7EaGpSLaP9ivhVg1YebkKJp4WxYXp X-Received: by 2002:aca:c08b:: with SMTP id q133mr937294oif.46.1582272058866; Fri, 21 Feb 2020 00:00:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582272058; cv=none; d=google.com; s=arc-20160816; b=fMwEMuXSrSKjHVWIZxovl5AiIiDU3Sdde16ou6Ov3x9F3F3KeuXJEjSyX0XJFWl6I8 1QIYWAvwnUqYHOnz/zb+JgjDA6u7+hq2rKfnbgRzyyuB7EI5d9u5k3tF4fWqn1ai/J/X oNOS9FnkzJZg5fbzp3joTPWgU6H7MYIVMPjD+zkZ/JvWaTPaXhWqiKh6jETwO/socPx6 pWywUegPRmsSg1COXzVfhR6uDcIDavneKY2wgGyTKGYUWMaC0e7FxPPYmj+cm6tTxV3/ n6YnULYLpgAGQlGQEi1TXoCuiXODkwpgyXqk9ZcjSE6sLKFaaQzIHIn/p2SckTZuZpGy +hOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nr4y9xVU4Nm9EN5Cr8OfQ10Jwa5v9Y5wP9KQvcQqGXE=; b=TVm4tWX3iD+x69TRPEqsdJ35Qzw95IW2a/ovat3KX7WWjiU+bXlKMqMdF4vO6dY+w8 Bv5Vn8Da7HakphNrVDRw0mEnhV44/b5J5mN7AFzmj5AmJElCJIOwZzU1PRmpw5T0LnMV PgkQBt148C7PB5OjDGPIrjRvCuCXEMn+1GDEwUXtPArc6AUQitJ4cet4ITDmFm56Dyyp G+Rj3r80yUydBSy/9PRHiLZJlMwlsdlHBdn6x/QWtdXKgdqQ0RGkTRbuxuYn0Wj5VXrF UQcskgYYNlFvjKmaf15XVUG3emRE5cufC/rf4CRiwbXZpH/isLCA9U9SxsgnAXFFScdL SpVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=m3+w8DCU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y71si417436oia.82.2020.02.21.00.00.46; Fri, 21 Feb 2020 00:00:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=m3+w8DCU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731104AbgBUIAm (ORCPT + 99 others); Fri, 21 Feb 2020 03:00:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:32894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731100AbgBUIAk (ORCPT ); Fri, 21 Feb 2020 03:00:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DC3C222C4; Fri, 21 Feb 2020 08:00:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582272040; bh=z0rNwAgT4RhdH7E/PP6WgAWT6eALymRlsnU1oUbYAkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m3+w8DCUZNrrmoV2ibE/1wKPjONbE7ydVr90nQh6Hbn1CxBRVFhywEAeEXBBxKMA8 xQwgu1+AL3LdBcdbzvEjpwKEQi40p9Ucoi1cQ5KMVX35vP1fXm4rPsyXU69/ot0K0u jilldGstHffPTxQ3+WsMpdR4vgXO7vMDP/e0pf9E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve French , Oleg Kravtsov , Ronnie Sahlberg , Pavel Shilovsky , Sasha Levin Subject: [PATCH 5.5 392/399] cifs: log warning message (once) if out of disk space Date: Fri, 21 Feb 2020 08:41:57 +0100 Message-Id: <20200221072438.042478510@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French [ Upstream commit d6fd41905ec577851734623fb905b1763801f5ef ] We ran into a confusing problem where an application wasn't checking return code on close and so user didn't realize that the application ran out of disk space. log a warning message (once) in these cases. For example: [ 8407.391909] Out of space writing to \\oleg-server\small-share Signed-off-by: Steve French Reported-by: Oleg Kravtsov Reviewed-by: Ronnie Sahlberg Reviewed-by: Pavel Shilovsky Signed-off-by: Sasha Levin --- fs/cifs/smb2pdu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 0a3b37abc5e12..6c9497c18f0b8 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -4029,6 +4029,9 @@ smb2_writev_callback(struct mid_q_entry *mid) wdata->cfile->fid.persistent_fid, tcon->tid, tcon->ses->Suid, wdata->offset, wdata->bytes, wdata->result); + if (wdata->result == -ENOSPC) + printk_once(KERN_WARNING "Out of space writing to %s\n", + tcon->treeName); } else trace_smb3_write_done(0 /* no xid */, wdata->cfile->fid.persistent_fid, -- 2.20.1