Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1598249ybv; Fri, 21 Feb 2020 00:01:56 -0800 (PST) X-Google-Smtp-Source: APXvYqwwnilMBdubZAJmYfSTXrUVlvFsgOETUxSAvolCmW7LeeLbk4em18V2EWi5Q2Y5UFoAhT8U X-Received: by 2002:aca:e146:: with SMTP id y67mr907816oig.93.1582272116647; Fri, 21 Feb 2020 00:01:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582272116; cv=none; d=google.com; s=arc-20160816; b=x+sLuPmK76+67gOlEpY5R6TAlDOsdzP7UYR5fFK9Zv7IDW9FXL1Wcs9j2FKa9mcjtG CSCfhENLMPlaFmRBCyZJTV8PXi2Na9UrYN/JWxOhwduAgl0N5dl5i1wW96Im/5brxeDm 8dsRLhaAcilmnv1pwF6lkzVG/VKsBl5cFbvY9qolymvtiFjg6IZ4BmeZD+7S+tbs3hSM 9KR1K65andGcGVnPFtH+7Xezjq9HVXwYyBPVOTEadsj6a9WUJPoo4SNSPwvuu6S7ywcz PrYcuPu6jYGm+k8Yl3thHjVAyovrxlB6TxNksf6EmM6ZIYtyEbTEphBKXG5JQKq61H1K USbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jQ4EpUBrOr6HM9w8Oz53IXfZ91vrKln/2F+dPNzi9t0=; b=jPOcxDUsRnDnsq/lsC9CSVbmoq1dWuOF2UO3J+9AC4WTU5yt0Ht4JtLeviEYZ+EmMq B69zPRyUDJc3zyVrJbfJ4wEKEaJuJFIu+8a5nnPM2WAzZTrHvH1R5a6LAyMwbgbDvvNG Dxp3A8n+r86SNrE2Ma0/jgvu5uV7myyLM/mAlyGWYE5ZCCXaE6aIJ2k3C0/OWn8lxXNm NG9CcIQLZC8oo6cHm1ZFHuh9r53JSfI1EmCm9i7260mq0Dr+IHfCq5iuhmDA3NDzNeUh rqGGqSAYHx5d2yPU7dfMoF2oSUQSRQnS8Qj43drSHSa4wwaZ2xD+JF2+FF+/aMYp3HYE F+2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oc555iWM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x12si993368oto.194.2020.02.21.00.01.43; Fri, 21 Feb 2020 00:01:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oc555iWM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731089AbgBUIAg (ORCPT + 99 others); Fri, 21 Feb 2020 03:00:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:32792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731083AbgBUIAg (ORCPT ); Fri, 21 Feb 2020 03:00:36 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26B6F206ED; Fri, 21 Feb 2020 08:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582272035; bh=vCOwDC4HiMKfA9asIcQGpE8w0AH9BpB7uecmviq9Qsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oc555iWMlm83sUjlvAONGDMOemnJzzH70SK7UARQPdrVK+i32xZ/W5OQARVQXT0VW U7SadToKB2pdrjBw5wvrxKdEhuGb/4z83jL9fYhbsrDbmfz9xCebEfrsLyBieBvEWw TikUBnY0pMBQ190M965dCJIzjxBU2FuundeXVISw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maciej Fijalkowski , Daniel Borkmann , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Sasha Levin Subject: [PATCH 5.5 390/399] i40e: Relax i40e_xsk_wakeups return value when PF is busy Date: Fri, 21 Feb 2020 08:41:55 +0100 Message-Id: <20200221072437.894914775@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maciej Fijalkowski [ Upstream commit c77e9f09143822623dd71a0fdc84331129e97c3a ] Return -EAGAIN instead of -ENETDOWN to provide a slightly milder information to user space so that an application will know to retry the syscall when __I40E_CONFIG_BUSY bit is set on pf->state. Fixes: b3873a5be757 ("net/i40e: Fix concurrency issues between config flow and XSK") Signed-off-by: Maciej Fijalkowski Signed-off-by: Daniel Borkmann Acked-by: Björn Töpel Link: https://lore.kernel.org/bpf/20200205045834.56795-2-maciej.fijalkowski@intel.com Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c index f73cd917c44f7..3156de786d955 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c @@ -791,7 +791,7 @@ int i40e_xsk_wakeup(struct net_device *dev, u32 queue_id, u32 flags) struct i40e_ring *ring; if (test_bit(__I40E_CONFIG_BUSY, pf->state)) - return -ENETDOWN; + return -EAGAIN; if (test_bit(__I40E_VSI_DOWN, vsi->state)) return -ENETDOWN; -- 2.20.1