Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1619072ybv; Fri, 21 Feb 2020 00:24:25 -0800 (PST) X-Google-Smtp-Source: APXvYqy+0P/4Kq00+4HL7Ur88A8meRJ6kMuZBevTTwKNGOaTliGveksiV247Vyz5RUMeEY/0/DHz X-Received: by 2002:aca:ba55:: with SMTP id k82mr1002844oif.94.1582273465517; Fri, 21 Feb 2020 00:24:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582273465; cv=none; d=google.com; s=arc-20160816; b=pI1eG5I78awDbM52+gcV2KtJiXcKpXig2/kijzbISsnMC5/6KhkC8zAp+WtS/PDETR GCEpHP7ZuYF/5A7mI5MYEc/+inRIKbmFpzTZMob8HHdc/lZ4MgvPMlnw+ejdN91KEDRa 1XkO+yIAoB9NLu6XAAyCLjwt/stJq5PtXytXyUyIBYTlAJ8K5quAtkfiBiPTWUM+06mJ Df2E/vcwI8axkdiI+fI+PJSw0vOwrreQdXkwARmh2tENkYrA3a5KNNpKheIvmUshgQOX RpvhbyrOi3mi0IUyrve/UBDCwXtnA21JH49ur0vZ/qLM3JgWbcWy2c1omoq8BygARwIs v6qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=o4UnIWLEYvWv71aXxpF8QdmBJH6UaZO+QeZ9nIVvgpQ=; b=fx+X+dtDyi+4CrV8bL7VB5RCq5G/3vz8RC4vJ6VRLPcCuvPrDxShF/s8Plxs+7XU3p I1JBFL9rdkHJSpTVcHYiCZnbtvhqPEN+fUeHdRO66oF4FmaAr5hICvQSD50rLw69ZQzi uCRsDkiJwopvnQdCGrJvLdgpregSsQlPb6morXEdX2eXA1EwCe0tHmmMpEbLqA3cYUDg 5pHdes3/+9aaNrkuMdrNM07Xr9dJGQbGrfVv1cGbgxCP5WOtYxaJMzqBri8D6arLuwnj CGtYiO1ejqp55lSECuemMEywGso2mvF21rfLaN8sFEOZrbhKqX5io9+O/aVxa+rAdyAd 5viQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lZwqciHK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x207si436505oif.193.2020.02.21.00.24.13; Fri, 21 Feb 2020 00:24:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lZwqciHK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388502AbgBUIXc (ORCPT + 99 others); Fri, 21 Feb 2020 03:23:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:35588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388490AbgBUIXb (ORCPT ); Fri, 21 Feb 2020 03:23:31 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1325424676; Fri, 21 Feb 2020 08:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582273410; bh=HhQ4HBxToqOlP2WfNDtZs5pT2ABW7zoq0eEpp6vCOrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lZwqciHKW8VEhTSe/n6PlT6w5DnsTHsdFDV+IJLnYJK6EEyVCcEriGZMOiCcF+plF zEPSyLk17aHEB9uOgJpmWACYN04QsUCP/ieX94wLkYmsaTZKRDF2o2XdNaIwhtOMGt 2v4VN4wsTbqnFKKsdQkUs+gQrhQ6NkfSx2eQn7E8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang Chen , Christoph Hellwig , Coly Li , Jens Axboe , Sasha Levin Subject: [PATCH 4.19 159/191] bcache: cached_dev_free needs to put the sb page Date: Fri, 21 Feb 2020 08:42:12 +0100 Message-Id: <20200221072309.946803647@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072250.732482588@linuxfoundation.org> References: <20200221072250.732482588@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang Chen [ Upstream commit e8547d42095e58bee658f00fef8e33d2a185c927 ] Same as cache device, the buffer page needs to be put while freeing cached_dev. Otherwise a page would be leaked every time a cached_dev is stopped. Signed-off-by: Liang Chen Signed-off-by: Christoph Hellwig Signed-off-by: Coly Li Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/bcache/super.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index c45d9ad010770..5b5cbfadd003d 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1226,6 +1226,9 @@ static void cached_dev_free(struct closure *cl) mutex_unlock(&bch_register_lock); + if (dc->sb_bio.bi_inline_vecs[0].bv_page) + put_page(bio_first_page_all(&dc->sb_bio)); + if (!IS_ERR_OR_NULL(dc->bdev)) blkdev_put(dc->bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); -- 2.20.1